Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing edit to generate-openapi #1626

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

testing edit to generate-openapi #1626

wants to merge 2 commits into from

Conversation

swang392
Copy link
Contributor

@swang392 swang392 commented Jan 15, 2025

What does this PR do?

do not merge!!
Testing edit to generate-openapi to cause error when warning occurs in the output of make generate-openapi command
I removed // +listType=atomic from OtelCollectorFeatureConfig's Ports field in api/datadoghq/v2alpha1/datadogagent_types.go -> running make generate should lead to an API rule violation error

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@swang392 swang392 added this to the v1.13.0 milestone Jan 15, 2025
@swang392 swang392 added enhancement New feature or request do-not-merge labels Jan 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.82%. Comparing base (841842e) to head (994811c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1626   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files         217      217           
  Lines       20874    20874           
=======================================
  Hits        10191    10191           
  Misses      10147    10147           
  Partials      536      536           
Flag Coverage Δ
unittests 48.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841842e...994811c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants