Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otel collector configdata annotations (#1628) #1630

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

swang392
Copy link
Contributor

What does this PR do?

Cherry-pick #1628

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@swang392 swang392 requested a review from a team as a code owner January 17, 2025 15:12
@swang392 swang392 added the bug Something isn't working label Jan 17, 2025
@swang392 swang392 added this to the v1.12.0 milestone Jan 17, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 48.78%. Comparing base (af8c5e7) to head (704155a).

Files with missing lines Patch % Lines
...ller/datadogagent/feature/otelcollector/feature.go 66.66% 8 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.12    #1630      +/-   ##
==========================================
+ Coverage   48.76%   48.78%   +0.02%     
==========================================
  Files         235      235              
  Lines       21125    21145      +20     
==========================================
+ Hits        10301    10315      +14     
- Misses      10287    10291       +4     
- Partials      537      539       +2     
Flag Coverage Δ
unittests 48.78% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ller/datadogagent/feature/otelcollector/feature.go 86.50% <66.66%> (-2.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af8c5e7...704155a. Read the comment docs.

@swang392 swang392 merged commit c54912e into v1.12 Jan 17, 2025
16 checks passed
@swang392 swang392 deleted the cherry-pick-1628 branch January 17, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants