Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-4500] Add EKS Clusterrole Rule for EKS control plane metrics #1651

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

justin-lesko
Copy link

@justin-lesko justin-lesko commented Feb 3, 2025

What does this PR do?

This PR adds a clusterrole rule necessary to allow the agent to query the EKS metrics API as described in the official AWS blog post.

Motivation

Functional control plane metric reporting.

Additional Notes

The complementary helm chart PR is: DataDog/helm-charts#1687

Minimum Agent Versions

Describe your test plan

The testing documentation is found in the description of DataDog/helm-charts#1687.

  1. I deployed the operator
  2. I used the operator to deploy the agent
  3. I validated that the appropriate rules were granted to both the datadog-agent and datadog-cluster-checks-runner clusterroles.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@justin-lesko justin-lesko changed the title Add rule to clusterrole so the node agent can query the EKS control p… [CONTINT-4500] Add EKS Clusterrole Rule for EKS control plane metrics Feb 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 49.13%. Comparing base (8b4ebea) to head (2328a9c).

Files with missing lines Patch % Lines
...troller/datadogagent/feature/enabledefault/rbac.go 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
- Coverage   49.17%   49.13%   -0.04%     
==========================================
  Files         218      218              
  Lines       21033    21047      +14     
==========================================
  Hits        10342    10342              
- Misses      10150    10164      +14     
  Partials      541      541              
Flag Coverage Δ
unittests 49.13% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...troller/datadogagent/feature/enabledefault/rbac.go 15.70% <0.00%> (-0.74%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4ebea...2328a9c. Read the comment docs.

@justin-lesko
Copy link
Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-05 20:51:34 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-05 22:15:27 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@justin-lesko
Copy link
Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-02-05 22:15:25 UTC ℹ️ Devflow: /remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants