Add EDS Support #591
Merged
Add EDS Support #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
celenechang
reviewed
Aug 10, 2022
| var result reconcile.Result | ||
| var err error | ||
|
|
||
| // Set DatadogAgent instance instance as the owner and controller |
There was a problem hiding this comment.
Suggested change
| // Set DatadogAgent instance instance as the owner and controller | |
| // Set DatadogAgent instance as the owner and controller |
celenechang
reviewed
Aug 10, 2022
| return reconcile.Result{}, err | ||
| } | ||
|
|
||
| // From here the PodTemplateSpec should be ready, we can generate the hash that will be use to compare this extendeddaemonset with the current (if exist). |
There was a problem hiding this comment.
Suggested change
| // From here the PodTemplateSpec should be ready, we can generate the hash that will be use to compare this extendeddaemonset with the current (if exist). | |
| // From here the PodTemplateSpec should be ready, we can generate the hash that will be used to compare this extendeddaemonset with the current one (if it exists). |
celenechang
reviewed
Aug 10, 2022
| } | ||
|
|
||
| currentEDS := &edsv1alpha1.ExtendedDaemonSet{} | ||
| alreadyExist := true |
celenechang
reviewed
Aug 10, 2022
| // check if same hash | ||
| needUpdate := !comparison.IsSameSpecMD5Hash(hash, currentEDS.GetAnnotations()) | ||
| if !needUpdate { | ||
| // Even if the EDS is still the same, it's status might have |
There was a problem hiding this comment.
Suggested change
| // Even if the EDS is still the same, it's status might have | |
| // Even if the EDS is still the same, its status might have |
celenechang
reviewed
Aug 10, 2022
| now := metav1.NewTime(time.Now()) | ||
| newStatus.Agent = datadoghqv2alpha1.UpdateExtendedDaemonSetStatus(currentEDS, newStatus.Agent, &now) | ||
|
|
||
| // no need to update the EDS to stop here the process |
There was a problem hiding this comment.
Suggested change
| // no need to update the EDS to stop here the process | |
| // Stop reconcile loop since EDS hasn't changed |
celenechang
reviewed
Aug 10, 2022
|
|
||
| logger.Info("Updating ExtendedDaemonSet") | ||
|
|
||
| // TODO: these parameter can be added to the override.PodTemplateSpec. (it exist in v1alpha) |
There was a problem hiding this comment.
Suggested change
| // TODO: these parameter can be added to the override.PodTemplateSpec. (it exist in v1alpha) | |
| // TODO: these parameters can be added to the override.PodTemplateSpec. (It exists in v1alpha1) |
celenechang
reviewed
Aug 10, 2022
| } | ||
| event := buildEventInfo(updateEDS.Name, updateEDS.Namespace, extendedDaemonSetKind, datadog.UpdateEvent) | ||
| r.recordEvent(dda, event) | ||
| updateStatusFunc(updateEDS, newStatus, now, metav1.ConditionTrue, "Extended_Daemonset_updated", "ExtendedDaemonSet updated") |
There was a problem hiding this comment.
Suggested change
| updateStatusFunc(updateEDS, newStatus, now, metav1.ConditionTrue, "Extended_Daemonset_updated", "ExtendedDaemonSet updated") | |
| updateStatusFunc(updateEDS, newStatus, now, metav1.ConditionTrue, "ExtendedDaemonSet_updated", "ExtendedDaemonSet updated") |
maybe?
celenechang
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds EDS support to v2 reconciler
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
supportExtendedDaemonset: example in helm templateskubectl label node <node> agent.datadoghq.com/component=agent agent.datadoghq.com/name=datadog