f

DataDog · Jan 14, 2025 · 51071ce · 51071ce
1 parent e64c036
commit 51071ce
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 28 deletions.
diff --git a/contrib/aws/internal/span_pointers/span_pointers.go b/contrib/aws/internal/span_pointers/span_pointers.go
@@ -62,7 +62,7 @@ func HandleS3Operation(in middleware.DeserializeInput, out middleware.Deserializ
 			"link.kind": LinkKind,
 		},
 	}
-	span.AddSpanLinks(link)
+	//span.AddSpanLinks(link)
 }
 
 // generatePointerHash generates a unique hash from an array of strings by joining them with | before hashing.

diff --git a/ddtrace/ddtrace.go b/ddtrace/ddtrace.go
@@ -79,9 +79,6 @@ type Span interface {
 	// item should propagate to all descendant spans, both in- and cross-process.
 	SetBaggageItem(key, val string)
 
-	// AddSpanLinks appends the given span links.
-	AddSpanLinks(links ...SpanLink)
-
 	// Finish finishes the current span with the given options. Finish calls should be idempotent.
 	Finish(opts ...FinishOption)
 

diff --git a/ddtrace/internal/globaltracer.go b/ddtrace/internal/globaltracer.go
@@ -80,9 +80,6 @@ func (NoopSpan) BaggageItem(_ string) string { return "" }
 // SetBaggageItem implements ddtrace.Span.
 func (NoopSpan) SetBaggageItem(_, _ string) {}
 
-// AddSpanLinks implements ddtrace.Span
-func (NoopSpan) AddSpanLinks(_ ...ddtrace.SpanLink) {}
-
 // Finish implements ddtrace.Span.
 func (NoopSpan) Finish(_ ...ddtrace.FinishOption) {}
 

diff --git a/ddtrace/mocktracer/mockspan.go b/ddtrace/mocktracer/mockspan.go
@@ -110,11 +110,6 @@ type mockspan struct {
 	links     []ddtrace.SpanLink
 }
 
-func (s *mockspan) AddSpanLinks(links ...ddtrace.SpanLink) {
-	//TODO implement me
-	panic("implement me")
-}
-
 // SetTag sets a given tag on the span.
 func (s *mockspan) SetTag(key string, value interface{}) {
 	s.Lock()
@@ -134,7 +129,6 @@ func (s *mockspan) SetTag(key string, value interface{}) {
 		}
 	}
 	s.tags[key] = value
-	fmt.Printf("Done setting tags: %+v\n", s.tags)
 }
 
 func (s *mockspan) FinishTime() time.Time {

diff --git a/ddtrace/tracer/civisibility_tslv.go b/ddtrace/tracer/civisibility_tslv.go
@@ -200,11 +200,6 @@ func (e *ciVisibilityEvent) SetBaggageItem(key, val string) {
 	e.span.SetBaggageItem(key, val)
 }
 
-// AddSpanLinks iml
-func (e *ciVisibilityEvent) AddSpanLinks(links ...ddtrace.SpanLink) {
-	e.span.SpanLinks = append(e.span.SpanLinks, links...)
-}
-
 // Finish completes the event's span with optional finish options.
 //
 // Parameters:

diff --git a/ddtrace/tracer/span.go b/ddtrace/tracer/span.go
@@ -464,16 +464,6 @@ func (s *span) setMetric(key string, v float64) {
 	}
 }
 
-// AddSpanLinks implements ddtrace.Span.
-func (s *span) AddSpanLinks(links ...ddtrace.SpanLink) {
-	s.Lock()
-	defer s.Unlock()
-	if s.finished {
-		return
-	}
-	s.SpanLinks = append(s.SpanLinks, links...)
-}
-
 // Finish closes this Span (but not its children) providing the duration
 // of its part of the tracing session.
 func (s *span) Finish(opts ...ddtrace.FinishOption) {