Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ddtrace/tracer: moving trace sampling to the end of the lifecycle #2433

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Dec 13, 2023

Benchmarks

Benchmark execution time: 2023-12-14 15:21:46

Comparing candidate commit 7395756 in PR branch shevchenko/add-tag-sampling-on-finish with baseline commit 80ad819 in branch shevchenko/update-trace-rules-to-glob.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@dianashevchenko dianashevchenko changed the title Shevchenko/add tag sampling on finish [WIP] ddtrace/tracer: moving trace sampling to the end of the the Dec 14, 2023
@dianashevchenko dianashevchenko changed the title [WIP] ddtrace/tracer: moving trace sampling to the end of the the [WIP] ddtrace/tracer: moving trace sampling to the end of the lifecycle Dec 14, 2023
Base automatically changed from shevchenko/update-trace-rules-to-glob to shevchenko/tag-resource-sampling December 19, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant