v2/contrib: update contrib naming policy #2536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Contrib naming policy has been changed. The previous one, if applied consistently, would lead to a bigger number of breaking changes.
The new one provides a better balance between our current existing contribs and having a consistent way to know from the import URL - combining it with the current version of the integrated package - what versions are supported in the integration.
The current contribs have been updated according to the new policy:
IBM/sarama
(only v1 is available)olivere/elastic.v5
(the minimum supported version is v5,gopkg.in/olivere/elastic.v5
)segmentio/kafka-go
(only v0 available, suffix not needed).valyala/fasthttp
(only v1 is available).The rest of integrations don’t need any change, as:
github.com/twitch/twirp
).Test methodology: downgrade the integrated packages to their highest v0 version and run
go test -v ./...
. Code must compile and tests must pass.Motivation
Fix #544
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!