Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/appsec: smaller matrix and faster jobs #2541

Merged
merged 76 commits into from
Feb 27, 2024

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Feb 7, 2024

What does this PR do?

  1. Fix the Go modules caching that wasn't working at all
  2. Reuse a runner as much as possible. For instance, no longer ask a runner for the sake of recompiling a test differently.
  3. Remove a lot of matrix cases that will be now covered by go-libddwaf's CI
  4. Reduce the amount of macos jobs to its minimum, wich is oldest and latest.

Motivation

  • Faster CI
  • Less flaky CI

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@Julio-Guerra Julio-Guerra added the ci label Feb 7, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2024

Benchmarks

Benchmark execution time: 2024-02-26 16:40:25

Comparing candidate commit c53a196 in PR branch julio.guerra/ci-gh-enterprise-runner with baseline commit 6a6746f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@Julio-Guerra Julio-Guerra requested review from a team as code owners February 14, 2024 15:41
@darccio
Copy link
Member

darccio commented Feb 14, 2024

@Julio-Guerra If I'm looking at the right place and reading it right, some tests are incredibly improved :)

Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some relatively minor comments only

.github/workflows/appsec.yml Outdated Show resolved Hide resolved
.github/workflows/appsec.yml Outdated Show resolved Hide resolved
.github/workflows/appsec.yml Outdated Show resolved Hide resolved
.github/workflows/appsec.yml Show resolved Hide resolved
.github/workflows/appsec.yml Show resolved Hide resolved
.github/workflows/appsec.yml Outdated Show resolved Hide resolved
.github/workflows/appsec.yml Outdated Show resolved Hide resolved
.github/workflows/appsec.yml Outdated Show resolved Hide resolved
.github/workflows/appsec.yml Show resolved Hide resolved
.github/workflows/appsec.yml Outdated Show resolved Hide resolved
@eliottness eliottness enabled auto-merge (squash) February 26, 2024 13:43
@Julio-Guerra Julio-Guerra merged commit b855917 into main Feb 27, 2024
191 checks passed
@Julio-Guerra Julio-Guerra deleted the julio.guerra/ci-gh-enterprise-runner branch February 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants