internal: appsec: switch appsec event tag from json to messagepack using meta_struct #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliott Bouhana <[email protected]>
APPSEC-51698 Signed-off-by: Eliott Bouhana <[email protected]>
github-actions
bot
added
the
apm:ecosystem
eliottness
force-pushed
the
eliott.bouhana/APPSEC-51697
branch
from
fd8438d to
42ecfa3
Compare
eliottness
force-pushed
the
eliott.bouhana/APPSEC-51880
branch
from
6d6e18c to
1491e59
Compare
BenchmarksBenchmark execution time: 2024-02-23 13:36:44 Comparing candidate commit 147955e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
Signed-off-by: Eliott Bouhana <[email protected]>
…ing meta_struct Signed-off-by: Eliott Bouhana <[email protected]>
…[]any but it supports map[string]any :[ Signed-off-by: Eliott Bouhana <[email protected]>
… in meta_struct Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
force-pushed
the
eliott.bouhana/APPSEC-51880
branch
from
e4d58cb to
147955e
Compare
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
eliottness
force-pushed
the
eliott.bouhana/APPSEC-51697
branch
7 times, most recently
from
c3350e9 to
3b9f898
Compare
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR optimize the was appsec events are sent to the backend by using the new
meta_structspan field to sent structured data to the backend without resorting to json in a string.Motivation
Marshaling json values directly in the customer hot path adds overhead to ASM that can now be avoided using this method that moves serializing to the agent writer goroutine.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!
APPSEC-51698
Signed-off-by: Eliott Bouhana [email protected]