contrib/database/sql: use tracer-level tags on contrib's statsd.Client #2635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The "DB Stats" metrics reported by the database/sql integration now accurately report
hostname
,env
,lang
andlang_version
tags that were previously private to the tracer.The tracer now publishes these tags so that integrations that submit statsd payloads (currently only database/sql) can use them.
The metrics also report the
service
tag, which is unique to the contrib. Theservice
tag should not be shared from tracer to contribs, as contribs determine their own service name.Motivation
Tags such as
service
andenv
are critical for correlating data across Datadog products (e.g, Metrics and APM), so it was important that these tags report accurately on our metrics.Ref: https://docs.datadoghq.com/getting_started/tagging/unified_service_tagging/
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!