Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Extensions system tests to CI #3112

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Jan 22, 2025

What does this PR do?

Add the Service Extensions system tests scenarios to the CI.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@e-n-0 e-n-0 requested review from a team as code owners January 22, 2025 16:35
@e-n-0 e-n-0 marked this pull request as draft January 22, 2025 16:35
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 22, 2025

Datadog Report

Branch report: flavien/envoy/enable-system-tests
Commit report: c22252c
Test service: dd-trace-go

✅ 0 Failed, 5201 Passed, 72 Skipped, 2m 19.4s Total Time

@e-n-0 e-n-0 marked this pull request as ready for review January 22, 2025 16:45
@eliottness eliottness enabled auto-merge (squash) January 22, 2025 16:57
@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2025

Benchmarks

Benchmark execution time: 2025-01-23 23:35:51

Comparing candidate commit ba55d87 in PR branch flavien/envoy/enable-system-tests with baseline commit 700f43e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@e-n-0 e-n-0 force-pushed the flavien/envoy/enable-system-tests branch from d88582c to ba55d87 Compare January 23, 2025 23:08
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: flavien/envoy/enable-system-tests
Commit report: a0ef2fd
Test service: dd-trace-go

✅ 0 Failed, 5207 Passed, 72 Skipped, 2m 47.27s Total Time

@eliottness eliottness merged commit 9f1ce94 into main Jan 23, 2025
176 checks passed
@eliottness eliottness deleted the flavien/envoy/enable-system-tests branch January 23, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants