Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix: improved performance on multiple benchmarks #3114

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

darccio
Copy link
Member

@darccio darccio commented Jan 23, 2025

What does this PR do?

Fixes multiple regressions on v2-dev, resulting on appropriate performance - at par with main - in multiple areas.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners January 23, 2025 17:58
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 23, 2025

Datadog Report

Branch report: dario.castane/langplat-168/bench-investigation
Commit report: fa0b980
Test service: dd-trace-go

✅ 0 Failed, 4095 Passed, 64 Skipped, 2m 51.15s Total Time

@darccio darccio merged commit c31e444 into v2-dev Jan 24, 2025
151 of 152 checks passed
@darccio darccio deleted the dario.castane/langplat-168/bench-investigation branch January 24, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants