-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add codeowners to gotestsum report #3118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 5216 Passed, 72 Skipped, 2m 19.67s Total Time |
darccio
reviewed
Jan 28, 2025
darccio
approved these changes
Jan 28, 2025
hannahkm
added a commit
that referenced
this pull request
Jan 28, 2025
hannahkm
added a commit
that referenced
this pull request
Jan 28, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a script to enable reporting
CODEOWNER
to CI. Adding thefile
parameter to our XML report file will allow the DataDog CI to compare against ourCODEOWNERS
file and assign tags to each test in the backend, as detailed in our docs.The XML file already contains, for each
testcase
, aclassName
attribute that represents the full path to the test. For example,className=gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer
To derive the subdirectory, which would match lines in our existing
CODEOWNERS
file, we trim the beginning:file=/ddtrace/tracer
Note: the DataDog CI and JUnit XML will only recognize the
file
attribute if it is the last attribute in thetestcase
line.Motivation
When triaging failing or flaky tests, it's helpful to see at a glance who is responsible for a certain file or directory. This is already available in
dd-trace-py
,dd-trace-java
, anddd-trace-rb
.Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!