Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add codeowners to gotestsum report #3118

Merged
merged 12 commits into from
Jan 28, 2025
Merged

ci: add codeowners to gotestsum report #3118

merged 12 commits into from
Jan 28, 2025

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Jan 24, 2025

What does this PR do?

Adds a script to enable reporting CODEOWNER to CI. Adding the file parameter to our XML report file will allow the DataDog CI to compare against our CODEOWNERS file and assign tags to each test in the backend, as detailed in our docs.

image

The XML file already contains, for each testcase, a className attribute that represents the full path to the test. For example,

className=gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer

To derive the subdirectory, which would match lines in our existing CODEOWNERS file, we trim the beginning:

file=/ddtrace/tracer

Note: the DataDog CI and JUnit XML will only recognize the file attribute if it is the last attribute in the testcase line.

Motivation

When triaging failing or flaky tests, it's helpful to see at a glance who is responsible for a certain file or directory. This is already available in dd-trace-py, dd-trace-java, and dd-trace-rb.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Jan 24, 2025

Benchmarks

Benchmark execution time: 2025-01-28 16:24:42

Comparing candidate commit 5095868 in PR branch hannahkm/add-codeowners with baseline commit f0ed584 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 24, 2025

Datadog Report

Branch report: hannahkm/add-codeowners
Commit report: 6e34e02
Test service: dd-trace-go

✅ 0 Failed, 5216 Passed, 72 Skipped, 2m 19.67s Total Time

@hannahkm hannahkm marked this pull request as ready for review January 27, 2025 16:00
@hannahkm hannahkm requested review from a team as code owners January 27, 2025 16:00
@hannahkm hannahkm enabled auto-merge (squash) January 28, 2025 15:58
@hannahkm hannahkm merged commit 46362ed into main Jan 28, 2025
176 checks passed
@hannahkm hannahkm deleted the hannahkm/add-codeowners branch January 28, 2025 16:39
hannahkm added a commit that referenced this pull request Jan 28, 2025
hannahkm added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants