Remove support for X-Forwarded in client IP resolution #7946

smola · 2024-11-13T14:20:37Z

What Does This Do

Remove X-Forwarded header from default client IP resolution.

Motivation

Unclear evidence of real world usage of this header, as well as its format. Support is dropped from default client IP resolution, but it can still be used with dd.trace.client-ip-header=x-forwarded (system property) of DD_TRACE_CLIENT_IP_HEADER=x-forwarded (environment variable).

The header is still collected on security events.

Support for parsing RFC 7239 (Forwarded format) is still maintained.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
~~[ ] Update the public documentation in case of new configuration flag or behavior~~

Jira ticket: APPSEC-55834

pr-commenter · 2024-11-25T09:30:20Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/x-forwarded
git_commit_date	1732489991	1732524487
git_commit_sha	`4925a50`	`ad3a959`
release_version	1.43.0-SNAPSHOT~4925a50233	1.43.0-SNAPSHOT~ad3a95960c

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732526839	1732526839
ci_job_id	718405034	718405034
ci_pipeline_id	49829537	49829537
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~ad3a95960c, baseline=1.43.0-SNAPSHOT~4925a50233

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086427
Total [baseline] (10.605 s) : 0, 10604515
Agent [candidate] (1.094 s) : 0, 1094072
Total [candidate] (10.5 s) : 0, 10499775
section appsec
Agent [baseline] (1.225 s) : 0, 1224960
Total [baseline] (10.724 s) : 0, 10723703
Agent [candidate] (1.224 s) : 0, 1224438
Total [candidate] (10.725 s) : 0, 10725433
section iast
Agent [baseline] (1.222 s) : 0, 1222010
Total [baseline] (10.931 s) : 0, 10931262
Agent [candidate] (1.217 s) : 0, 1216705
Total [candidate] (10.922 s) : 0, 10921906
section profiling
Agent [baseline] (1.316 s) : 0, 1315919
Total [baseline] (10.763 s) : 0, 10762566
Agent [candidate] (1.311 s) : 0, 1310754
Total [candidate] (10.789 s) : 0, 10789219

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.086 s	-
Agent	appsec	1.225 s	138.534 ms (12.8%)
Agent	iast	1.222 s	135.583 ms (12.5%)
Agent	profiling	1.316 s	229.492 ms (21.1%)
Total	tracing	10.605 s	-
Total	appsec	10.724 s	119.188 ms (1.1%)
Total	iast	10.931 s	326.748 ms (3.1%)
Total	profiling	10.763 s	158.052 ms (1.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.094 s	-
Agent	appsec	1.224 s	130.366 ms (11.9%)
Agent	iast	1.217 s	122.633 ms (11.2%)
Agent	profiling	1.311 s	216.682 ms (19.8%)
Total	tracing	10.5 s	-
Total	appsec	10.725 s	225.659 ms (2.1%)
Total	iast	10.922 s	422.131 ms (4.0%)
Total	profiling	10.789 s	289.445 ms (2.8%)

gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~ad3a95960c, baseline=1.43.0-SNAPSHOT~4925a50233

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.42 ms) : 0, 690420
BytebuddyAgent [candidate] (696.245 ms) : 0, 696245
GlobalTracer [baseline] (316.614 ms) : 0, 316614
GlobalTracer [candidate] (318.847 ms) : 0, 318847
AppSec [baseline] (54.381 ms) : 0, 54381
AppSec [candidate] (55.128 ms) : 0, 55128
Remote Config [baseline] (699.351 µs) : 0, 699
Remote Config [candidate] (692.964 µs) : 0, 693
Telemetry [baseline] (10.638 ms) : 0, 10638
Telemetry [candidate] (9.354 ms) : 0, 9354
section appsec
BytebuddyAgent [baseline] (709.662 ms) : 0, 709662
BytebuddyAgent [candidate] (710.579 ms) : 0, 710579
GlobalTracer [baseline] (315.229 ms) : 0, 315229
GlobalTracer [candidate] (314.203 ms) : 0, 314203
AppSec [baseline] (168.081 ms) : 0, 168081
AppSec [candidate] (166.006 ms) : 0, 166006
IAST [baseline] (19.622 ms) : 0, 19622
IAST [candidate] (20.684 ms) : 0, 20684
Remote Config [baseline] (644.878 µs) : 0, 645
Remote Config [candidate] (646.145 µs) : 0, 646
Telemetry [baseline] (7.882 ms) : 0, 7882
Telemetry [candidate] (8.988 ms) : 0, 8988
section iast
BytebuddyAgent [baseline] (813.725 ms) : 0, 813725
BytebuddyAgent [candidate] (809.507 ms) : 0, 809507
GlobalTracer [baseline] (307.599 ms) : 0, 307599
GlobalTracer [candidate] (306.232 ms) : 0, 306232
AppSec [baseline] (57.832 ms) : 0, 57832
AppSec [candidate] (58.104 ms) : 0, 58104
IAST [baseline] (20.962 ms) : 0, 20962
IAST [candidate] (20.977 ms) : 0, 20977
Remote Config [baseline] (616.618 µs) : 0, 617
Remote Config [candidate] (616.613 µs) : 0, 617
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (7.516 ms) : 0, 7516
section profiling
BytebuddyAgent [baseline] (686.925 ms) : 0, 686925
BytebuddyAgent [candidate] (683.742 ms) : 0, 683742
GlobalTracer [baseline] (435.283 ms) : 0, 435283
GlobalTracer [candidate] (432.871 ms) : 0, 432871
AppSec [baseline] (53.728 ms) : 0, 53728
AppSec [candidate] (53.583 ms) : 0, 53583
Remote Config [baseline] (659.63 µs) : 0, 660
Remote Config [candidate] (651.272 µs) : 0, 651
Telemetry [baseline] (7.7 ms) : 0, 7700
Telemetry [candidate] (7.646 ms) : 0, 7646
ProfilingAgent [baseline] (92.665 ms) : 0, 92665
ProfilingAgent [candidate] (93.366 ms) : 0, 93366
Profiling [baseline] (92.688 ms) : 0, 92688
Profiling [candidate] (93.39 ms) : 0, 93390

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~ad3a95960c, baseline=1.43.0-SNAPSHOT~4925a50233

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1099679
Total [baseline] (8.73 s) : 0, 8729744
Agent [candidate] (1.096 s) : 0, 1095536
Total [candidate] (8.68 s) : 0, 8679681
section iast
Agent [baseline] (1.224 s) : 0, 1223670
Total [baseline] (9.212 s) : 0, 9211548
Agent [candidate] (1.219 s) : 0, 1219091
Total [candidate] (9.191 s) : 0, 9190900
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.228 s) : 0, 1227999
Total [baseline] (9.184 s) : 0, 9184056
Agent [candidate] (1.214 s) : 0, 1213785
Total [candidate] (9.184 s) : 0, 9184309
section iast_TELEMETRY_OFF
Agent [baseline] (1.223 s) : 0, 1222754
Total [baseline] (9.209 s) : 0, 9209368
Agent [candidate] (1.225 s) : 0, 1225420
Total [candidate] (9.241 s) : 0, 9241109

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.1 s	-
Agent	iast	1.224 s	123.991 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.228 s	128.32 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.223 s	123.075 ms (11.2%)
Total	tracing	8.73 s	-
Total	iast	9.212 s	481.803 ms (5.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.184 s	454.311 ms (5.2%)
Total	iast_TELEMETRY_OFF	9.209 s	479.624 ms (5.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.096 s	-
Agent	iast	1.219 s	123.555 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.214 s	118.249 ms (10.8%)
Agent	iast_TELEMETRY_OFF	1.225 s	129.884 ms (11.9%)
Total	tracing	8.68 s	-
Total	iast	9.191 s	511.219 ms (5.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.184 s	504.628 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.241 s	561.428 ms (6.5%)

gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~ad3a95960c, baseline=1.43.0-SNAPSHOT~4925a50233

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (698.812 ms) : 0, 698812
BytebuddyAgent [candidate] (697.746 ms) : 0, 697746
GlobalTracer [baseline] (320.46 ms) : 0, 320460
GlobalTracer [candidate] (318.903 ms) : 0, 318903
AppSec [baseline] (55.107 ms) : 0, 55107
AppSec [candidate] (54.405 ms) : 0, 54405
Remote Config [baseline] (702.89 µs) : 0, 703
Remote Config [candidate] (684.101 µs) : 0, 684
Telemetry [baseline] (10.842 ms) : 0, 10842
Telemetry [candidate] (10.001 ms) : 0, 10001
section iast
BytebuddyAgent [baseline] (814.873 ms) : 0, 814873
BytebuddyAgent [candidate] (810.903 ms) : 0, 810903
GlobalTracer [baseline] (307.483 ms) : 0, 307483
GlobalTracer [candidate] (307.459 ms) : 0, 307459
AppSec [baseline] (57.023 ms) : 0, 57023
AppSec [candidate] (58.026 ms) : 0, 58026
IAST [baseline] (22.404 ms) : 0, 22404
IAST [candidate] (20.839 ms) : 0, 20839
Remote Config [baseline] (605.948 µs) : 0, 606
Remote Config [candidate] (602.769 µs) : 0, 603
Telemetry [baseline] (7.507 ms) : 0, 7507
Telemetry [candidate] (7.496 ms) : 0, 7496
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (816.838 ms) : 0, 816838
BytebuddyAgent [candidate] (808.045 ms) : 0, 808045
GlobalTracer [baseline] (310.338 ms) : 0, 310338
GlobalTracer [candidate] (305.969 ms) : 0, 305969
AppSec [baseline] (58.074 ms) : 0, 58074
AppSec [candidate] (57.371 ms) : 0, 57371
IAST [baseline] (20.827 ms) : 0, 20827
IAST [candidate] (20.697 ms) : 0, 20697
Remote Config [baseline] (605.31 µs) : 0, 605
Remote Config [candidate] (601.251 µs) : 0, 601
Telemetry [baseline] (7.532 ms) : 0, 7532
Telemetry [candidate] (7.391 ms) : 0, 7391
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (812.091 ms) : 0, 812091
BytebuddyAgent [candidate] (815.717 ms) : 0, 815717
GlobalTracer [baseline] (309.596 ms) : 0, 309596
GlobalTracer [candidate] (308.9 ms) : 0, 308900
AppSec [baseline] (58.313 ms) : 0, 58313
AppSec [candidate] (57.43 ms) : 0, 57430
IAST [baseline] (20.81 ms) : 0, 20810
IAST [candidate] (21.41 ms) : 0, 21410
Remote Config [baseline] (656.164 µs) : 0, 656
Remote Config [candidate] (631.016 µs) : 0, 631
Telemetry [baseline] (7.508 ms) : 0, 7508
Telemetry [candidate] (7.491 ms) : 0, 7491

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-25T08:57:24	2024-11-25T09:04:20
git_branch	master	smola/x-forwarded
git_commit_date	1732489991	1732524487
git_commit_sha	`4925a50`	`ad3a959`
release_version	1.43.0-SNAPSHOT~4925a50233	1.43.0-SNAPSHOT~ad3a95960c
start_time	2024-11-25T08:57:10	2024-11-25T09:04:07

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732525811	1732525811
ci_job_id	718405035	718405035
ci_pipeline_id	49829537	49829537
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ad3a95960c, baseline=1.43.0-SNAPSHOT~4925a50233
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.61 µs) : 350, 389
.   : milestone, 370,
iast (484.912 µs) : 464, 506
.   : milestone, 485,
iast_FULL (649.508 µs) : 628, 671
.   : milestone, 650,
iast_GLOBAL (517.694 µs) : 495, 540
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (485.476 µs) : 464, 507
.   : milestone, 485,
iast_INACTIVE (452.831 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (475.57 µs) : 454, 497
.   : milestone, 476,
tracing (448.762 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (378.703 µs) : 358, 399
.   : milestone, 379,
iast (488.103 µs) : 467, 510
.   : milestone, 488,
iast_FULL (653.075 µs) : 632, 675
.   : milestone, 653,
iast_GLOBAL (517.386 µs) : 496, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (490.613 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (450.011 µs) : 428, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (484.005 µs) : 462, 506
.   : milestone, 484,
tracing (445.791 µs) : 424, 468
.   : milestone, 446,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	369.61 µs [350.112 µs, 389.107 µs]	-
iast	484.912 µs [463.518 µs, 506.306 µs]	115.302 µs (31.2%)
iast_FULL	649.508 µs [627.848 µs, 671.169 µs]	279.898 µs (75.7%)
iast_GLOBAL	517.694 µs [495.357 µs, 540.031 µs]	148.084 µs (40.1%)
iast_HARDCODED_SECRET_DISABLED	485.476 µs [464.323 µs, 506.629 µs]	115.866 µs (31.3%)
iast_INACTIVE	452.831 µs [431.604 µs, 474.058 µs]	83.221 µs (22.5%)
iast_TELEMETRY_OFF	475.57 µs [454.009 µs, 497.131 µs]	105.961 µs (28.7%)
tracing	448.762 µs [427.742 µs, 469.782 µs]	79.152 µs (21.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.703 µs [358.454 µs, 398.952 µs]	-
iast	488.103 µs [466.647 µs, 509.559 µs]	109.401 µs (28.9%)
iast_FULL	653.075 µs [631.574 µs, 674.576 µs]	274.372 µs (72.5%)
iast_GLOBAL	517.386 µs [495.695 µs, 539.077 µs]	138.683 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED	490.613 µs [469.081 µs, 512.144 µs]	111.91 µs (29.6%)
iast_INACTIVE	450.011 µs [428.44 µs, 471.581 µs]	71.308 µs (18.8%)
iast_TELEMETRY_OFF	484.005 µs [461.62 µs, 506.389 µs]	105.302 µs (27.8%)
tracing	445.791 µs [423.7 µs, 467.881 µs]	67.088 µs (17.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ad3a95960c, baseline=1.43.0-SNAPSHOT~4925a50233
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.742 ms) : 1718, 1766
.   : milestone, 1742,
appsec_no_iast (1.766 ms) : 1742, 1790
.   : milestone, 1766,
iast (1.497 ms) : 1475, 1519
.   : milestone, 1497,
profiling (1.497 ms) : 1473, 1520
.   : milestone, 1497,
tracing (1.468 ms) : 1443, 1494
.   : milestone, 1468,
section candidate
no_agent (1.359 ms) : 1340, 1379
.   : milestone, 1359,
appsec (1.746 ms) : 1722, 1770
.   : milestone, 1746,
appsec_no_iast (1.748 ms) : 1724, 1773
.   : milestone, 1748,
iast (1.488 ms) : 1465, 1511
.   : milestone, 1488,
profiling (1.488 ms) : 1465, 1512
.   : milestone, 1488,
tracing (1.463 ms) : 1438, 1487
.   : milestone, 1463,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.343 ms [1.324 ms, 1.363 ms]	-
appsec	1.742 ms [1.718 ms, 1.766 ms]	398.579 µs (29.7%)
appsec_no_iast	1.766 ms [1.742 ms, 1.79 ms]	422.84 µs (31.5%)
iast	1.497 ms [1.475 ms, 1.519 ms]	153.61 µs (11.4%)
profiling	1.497 ms [1.473 ms, 1.52 ms]	153.185 µs (11.4%)
tracing	1.468 ms [1.443 ms, 1.494 ms]	125.125 µs (9.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.359 ms [1.34 ms, 1.379 ms]	-
appsec	1.746 ms [1.722 ms, 1.77 ms]	386.307 µs (28.4%)
appsec_no_iast	1.748 ms [1.724 ms, 1.773 ms]	388.829 µs (28.6%)
iast	1.488 ms [1.465 ms, 1.511 ms]	128.907 µs (9.5%)
profiling	1.488 ms [1.465 ms, 1.512 ms]	128.966 µs (9.5%)
tracing	1.463 ms [1.438 ms, 1.487 ms]	103.084 µs (7.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/x-forwarded
git_commit_date	1732489991	1732524487
git_commit_sha	`4925a50`	`ad3a959`
release_version	1.43.0-SNAPSHOT~4925a50233	1.43.0-SNAPSHOT~ad3a95960c

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732526369	1732526369
ci_job_id	718405038	718405038
ci_pipeline_id	49829537	49829537
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ad3a95960c, baseline=1.43.0-SNAPSHOT~4925a50233
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.361 ms) : 2320, 2403
.   : milestone, 2361,
iast (2.103 ms) : 2050, 2156
.   : milestone, 2103,
iast_GLOBAL (2.134 ms) : 2082, 2187
.   : milestone, 2134,
profiling (1.972 ms) : 1930, 2014
.   : milestone, 1972,
tracing (1.939 ms) : 1898, 1980
.   : milestone, 1939,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.358 ms) : 2317, 2399
.   : milestone, 2358,
iast (2.101 ms) : 2049, 2154
.   : milestone, 2101,
iast_GLOBAL (2.136 ms) : 2084, 2189
.   : milestone, 2136,
profiling (2.459 ms) : 2270, 2648
.   : milestone, 2459,
tracing (1.939 ms) : 1899, 1980
.   : milestone, 1939,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.463 ms, 1.486 ms]	-
appsec	2.361 ms [2.32 ms, 2.403 ms]	886.907 µs (60.2%)
iast	2.103 ms [2.05 ms, 2.156 ms]	628.726 µs (42.6%)
iast_GLOBAL	2.134 ms [2.082 ms, 2.187 ms]	660.023 µs (44.8%)
profiling	1.972 ms [1.93 ms, 2.014 ms]	497.936 µs (33.8%)
tracing	1.939 ms [1.898 ms, 1.98 ms]	464.934 µs (31.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.458 ms, 1.481 ms]	-
appsec	2.358 ms [2.317 ms, 2.399 ms]	888.257 µs (60.4%)
iast	2.101 ms [2.049 ms, 2.154 ms]	631.646 µs (43.0%)
iast_GLOBAL	2.136 ms [2.084 ms, 2.189 ms]	666.473 µs (45.3%)
profiling	2.459 ms [2.27 ms, 2.648 ms]	989.246 µs (67.3%)
tracing	1.939 ms [1.899 ms, 1.98 ms]	469.749 µs (32.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ad3a95960c, baseline=1.43.0-SNAPSHOT~4925a50233
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.473 s) : 15473000, 15473000
.   : milestone, 15473000,
appsec (15.111 s) : 15111000, 15111000
.   : milestone, 15111000,
iast (18.627 s) : 18627000, 18627000
.   : milestone, 18627000,
iast_GLOBAL (18.166 s) : 18166000, 18166000
.   : milestone, 18166000,
profiling (14.856 s) : 14856000, 14856000
.   : milestone, 14856000,
tracing (14.863 s) : 14863000, 14863000
.   : milestone, 14863000,
section candidate
no_agent (15.438 s) : 15438000, 15438000
.   : milestone, 15438000,
appsec (14.883 s) : 14883000, 14883000
.   : milestone, 14883000,
iast (18.833 s) : 18833000, 18833000
.   : milestone, 18833000,
iast_GLOBAL (18.01 s) : 18010000, 18010000
.   : milestone, 18010000,
profiling (14.952 s) : 14952000, 14952000
.   : milestone, 14952000,
tracing (14.912 s) : 14912000, 14912000
.   : milestone, 14912000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.473 s [15.473 s, 15.473 s]	-
appsec	15.111 s [15.111 s, 15.111 s]	-362.0 ms (-2.3%)
iast	18.627 s [18.627 s, 18.627 s]	3.154 s (20.4%)
iast_GLOBAL	18.166 s [18.166 s, 18.166 s]	2.693 s (17.4%)
profiling	14.856 s [14.856 s, 14.856 s]	-617.0 ms (-4.0%)
tracing	14.863 s [14.863 s, 14.863 s]	-610.0 ms (-3.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.438 s [15.438 s, 15.438 s]	-
appsec	14.883 s [14.883 s, 14.883 s]	-555.0 ms (-3.6%)
iast	18.833 s [18.833 s, 18.833 s]	3.395 s (22.0%)
iast_GLOBAL	18.01 s [18.01 s, 18.01 s]	2.572 s (16.7%)
profiling	14.952 s [14.952 s, 14.952 s]	-486.0 ms (-3.1%)
tracing	14.912 s [14.912 s, 14.912 s]	-526.0 ms (-3.4%)

smola changed the title ~~wip~~ Remove support for X-Forwarded in client IP resolution Nov 13, 2024

smola added the comp: core Tracer core label Nov 22, 2024

smola force-pushed the smola/x-forwarded branch 2 times, most recently from c994881 to b9f3e12 Compare November 25, 2024 07:38

Remove support for X-Forwarded in client IP resolution

ad3a959

smola force-pushed the smola/x-forwarded branch from b9f3e12 to ad3a959 Compare November 25, 2024 08:48

smola marked this pull request as ready for review November 25, 2024 11:55

smola requested review from a team as code owners November 25, 2024 11:55

smola requested review from manuel-alvarez-alvarez and Mariovido November 25, 2024 11:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove support for X-Forwarded in client IP resolution #7946

Remove support for X-Forwarded in client IP resolution #7946

smola commented Nov 13, 2024 •

edited

Loading

pr-commenter bot commented Nov 25, 2024

Remove support for X-Forwarded in client IP resolution #7946

Are you sure you want to change the base?

Remove support for X-Forwarded in client IP resolution #7946

Conversation

smola commented Nov 13, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Nov 25, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

smola commented Nov 13, 2024 •

edited

Loading