-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piotr wolski/instrument kafka connectors #7959
Draft
piochelepiotr
wants to merge
1
commit into
master
Choose a base branch
from
piotr-wolski/instrument-kafka-connectors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piochelepiotr
force-pushed
the
piotr-wolski/instrument-kafka-connectors
branch
from
November 18, 2024 21:53
5b5089c
to
ff9bbf2
Compare
piochelepiotr
force-pushed
the
piotr-wolski/instrument-kafka-connectors
branch
from
November 18, 2024 21:53
ff9bbf2
to
0127246
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~ff9bbf2b31, baseline=1.43.0-SNAPSHOT~6181783bd1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083325
Total [baseline] (8.61 s) : 0, 8610246
Agent [candidate] (1.085 s) : 0, 1085388
Total [candidate] (8.581 s) : 0, 8580686
section iast
Agent [baseline] (1.216 s) : 0, 1216372
Total [baseline] (9.145 s) : 0, 9144808
Agent [candidate] (1.211 s) : 0, 1211270
Total [candidate] (9.178 s) : 0, 9178293
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.221 s) : 0, 1221280
Total [baseline] (9.18 s) : 0, 9180006
Agent [candidate] (1.219 s) : 0, 1218550
Total [candidate] (9.114 s) : 0, 9114227
section iast_TELEMETRY_OFF
Agent [baseline] (1.207 s) : 0, 1206910
Total [baseline] (9.157 s) : 0, 9156817
Agent [candidate] (1.205 s) : 0, 1205132
Total [candidate] (9.142 s) : 0, 9142153
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~ff9bbf2b31, baseline=1.43.0-SNAPSHOT~6181783bd1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.15 ms) : 0, 689150
BytebuddyAgent [candidate] (688.716 ms) : 0, 688716
GlobalTracer [baseline] (316.966 ms) : 0, 316966
GlobalTracer [candidate] (316.963 ms) : 0, 316963
AppSec [baseline] (54.252 ms) : 0, 54252
AppSec [candidate] (54.193 ms) : 0, 54193
Remote Config [baseline] (675.65 µs) : 0, 676
Remote Config [candidate] (678.363 µs) : 0, 678
Telemetry [baseline] (8.56 ms) : 0, 8560
Telemetry [candidate] (11.099 ms) : 0, 11099
section iast
BytebuddyAgent [baseline] (809.253 ms) : 0, 809253
BytebuddyAgent [candidate] (804.738 ms) : 0, 804738
GlobalTracer [baseline] (307.65 ms) : 0, 307650
GlobalTracer [candidate] (306.563 ms) : 0, 306563
AppSec [baseline] (55.809 ms) : 0, 55809
AppSec [candidate] (56.044 ms) : 0, 56044
Remote Config [baseline] (604.516 µs) : 0, 605
Remote Config [candidate] (604.641 µs) : 0, 605
Telemetry [baseline] (7.39 ms) : 0, 7390
Telemetry [candidate] (7.422 ms) : 0, 7422
IAST [baseline] (21.92 ms) : 0, 21920
IAST [candidate] (22.153 ms) : 0, 22153
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (811.882 ms) : 0, 811882
BytebuddyAgent [candidate] (810.288 ms) : 0, 810288
GlobalTracer [baseline] (308.461 ms) : 0, 308461
GlobalTracer [candidate] (307.879 ms) : 0, 307879
AppSec [baseline] (57.288 ms) : 0, 57288
AppSec [candidate] (57.004 ms) : 0, 57004
Remote Config [baseline] (702.139 µs) : 0, 702
Remote Config [candidate] (622.915 µs) : 0, 623
Telemetry [baseline] (7.593 ms) : 0, 7593
Telemetry [candidate] (7.528 ms) : 0, 7528
IAST [baseline] (21.587 ms) : 0, 21587
IAST [candidate] (21.412 ms) : 0, 21412
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.239 ms) : 0, 801239
BytebuddyAgent [candidate] (800.289 ms) : 0, 800289
GlobalTracer [baseline] (305.534 ms) : 0, 305534
GlobalTracer [candidate] (305.905 ms) : 0, 305905
AppSec [baseline] (58.224 ms) : 0, 58224
AppSec [candidate] (56.744 ms) : 0, 56744
Remote Config [baseline] (613.251 µs) : 0, 613
Remote Config [candidate] (593.121 µs) : 0, 593
Telemetry [baseline] (7.386 ms) : 0, 7386
Telemetry [candidate] (7.276 ms) : 0, 7276
IAST [baseline] (20.239 ms) : 0, 20239
IAST [candidate] (20.658 ms) : 0, 20658
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~ff9bbf2b31, baseline=1.43.0-SNAPSHOT~6181783bd1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081098
Total [baseline] (10.445 s) : 0, 10445280
Agent [candidate] (1.086 s) : 0, 1085973
Total [candidate] (10.368 s) : 0, 10368433
section appsec
Agent [baseline] (1.219 s) : 0, 1218632
Total [baseline] (10.667 s) : 0, 10666697
Agent [candidate] (1.223 s) : 0, 1222718
Total [candidate] (10.703 s) : 0, 10702855
section iast
Agent [baseline] (1.221 s) : 0, 1220834
Total [baseline] (10.895 s) : 0, 10895499
Agent [candidate] (1.211 s) : 0, 1210657
Total [candidate] (10.934 s) : 0, 10934146
section profiling
Agent [baseline] (1.281 s) : 0, 1280736
Total [baseline] (10.849 s) : 0, 10849384
Agent [candidate] (1.282 s) : 0, 1282481
Total [candidate] (10.753 s) : 0, 10753004
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~ff9bbf2b31, baseline=1.43.0-SNAPSHOT~6181783bd1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.83 ms) : 0, 687830
BytebuddyAgent [candidate] (689.008 ms) : 0, 689008
GlobalTracer [baseline] (316.35 ms) : 0, 316350
GlobalTracer [candidate] (317.204 ms) : 0, 317204
AppSec [baseline] (54.07 ms) : 0, 54070
AppSec [candidate] (54.166 ms) : 0, 54166
Remote Config [baseline] (680.231 µs) : 0, 680
Remote Config [candidate] (674.381 µs) : 0, 674
Telemetry [baseline] (8.501 ms) : 0, 8501
Telemetry [candidate] (11.186 ms) : 0, 11186
section appsec
BytebuddyAgent [baseline] (705.235 ms) : 0, 705235
BytebuddyAgent [candidate] (708.644 ms) : 0, 708644
GlobalTracer [baseline] (314.79 ms) : 0, 314790
GlobalTracer [candidate] (315.605 ms) : 0, 315605
AppSec [baseline] (166.494 ms) : 0, 166494
AppSec [candidate] (166.683 ms) : 0, 166683
Remote Config [baseline] (639.617 µs) : 0, 640
Remote Config [candidate] (640.598 µs) : 0, 641
Telemetry [baseline] (7.764 ms) : 0, 7764
Telemetry [candidate] (7.787 ms) : 0, 7787
IAST [baseline] (20.129 ms) : 0, 20129
IAST [candidate] (19.306 ms) : 0, 19306
section iast
BytebuddyAgent [baseline] (812.724 ms) : 0, 812724
BytebuddyAgent [candidate] (804.569 ms) : 0, 804569
GlobalTracer [baseline] (308.228 ms) : 0, 308228
GlobalTracer [candidate] (305.259 ms) : 0, 305259
AppSec [baseline] (57.661 ms) : 0, 57661
AppSec [candidate] (57.285 ms) : 0, 57285
Remote Config [baseline] (599.726 µs) : 0, 600
Remote Config [candidate] (617.81 µs) : 0, 618
Telemetry [baseline] (7.393 ms) : 0, 7393
Telemetry [candidate] (7.491 ms) : 0, 7491
IAST [baseline] (20.452 ms) : 0, 20452
IAST [candidate] (21.724 ms) : 0, 21724
section profiling
BytebuddyAgent [baseline] (681.732 ms) : 0, 681732
BytebuddyAgent [candidate] (683.751 ms) : 0, 683751
GlobalTracer [baseline] (400.475 ms) : 0, 400475
GlobalTracer [candidate] (400.987 ms) : 0, 400987
AppSec [baseline] (54.678 ms) : 0, 54678
AppSec [candidate] (54.609 ms) : 0, 54609
Remote Config [baseline] (672.149 µs) : 0, 672
Remote Config [candidate] (739.324 µs) : 0, 739
Telemetry [baseline] (11.392 ms) : 0, 11392
Telemetry [candidate] (12.797 ms) : 0, 12797
ProfilingAgent [baseline] (92.998 ms) : 0, 92998
ProfilingAgent [candidate] (90.811 ms) : 0, 90811
Profiling [baseline] (93.021 ms) : 0, 93021
Profiling [candidate] (90.834 ms) : 0, 90834
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~ff9bbf2b31, baseline=1.43.0-SNAPSHOT~6181783bd1
dateFormat X
axisFormat %s
section baseline
no_agent (373.921 µs) : 354, 393
. : milestone, 374,
iast (495.929 µs) : 475, 517
. : milestone, 496,
iast_FULL (647.512 µs) : 626, 669
. : milestone, 648,
iast_GLOBAL (510.135 µs) : 489, 531
. : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (487.517 µs) : 466, 509
. : milestone, 488,
iast_INACTIVE (452.178 µs) : 431, 474
. : milestone, 452,
iast_TELEMETRY_OFF (478.866 µs) : 458, 500
. : milestone, 479,
tracing (448.023 µs) : 427, 469
. : milestone, 448,
section candidate
no_agent (370.348 µs) : 350, 391
. : milestone, 370,
iast (494.914 µs) : 473, 517
. : milestone, 495,
iast_FULL (649.316 µs) : 627, 671
. : milestone, 649,
iast_GLOBAL (524.831 µs) : 503, 546
. : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (490.088 µs) : 469, 511
. : milestone, 490,
iast_INACTIVE (454.679 µs) : 434, 475
. : milestone, 455,
iast_TELEMETRY_OFF (479.476 µs) : 459, 500
. : milestone, 479,
tracing (453.716 µs) : 433, 474
. : milestone, 454,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~ff9bbf2b31, baseline=1.43.0-SNAPSHOT~6181783bd1
dateFormat X
axisFormat %s
section baseline
no_agent (1.352 ms) : 1333, 1372
. : milestone, 1352,
appsec (1.743 ms) : 1721, 1765
. : milestone, 1743,
appsec_no_iast (1.765 ms) : 1742, 1789
. : milestone, 1765,
iast (1.499 ms) : 1477, 1522
. : milestone, 1499,
profiling (1.552 ms) : 1528, 1577
. : milestone, 1552,
tracing (1.46 ms) : 1436, 1485
. : milestone, 1460,
section candidate
no_agent (1.336 ms) : 1316, 1355
. : milestone, 1336,
appsec (1.734 ms) : 1710, 1757
. : milestone, 1734,
appsec_no_iast (1.74 ms) : 1716, 1764
. : milestone, 1740,
iast (1.505 ms) : 1482, 1527
. : milestone, 1505,
profiling (1.495 ms) : 1472, 1518
. : milestone, 1495,
tracing (1.481 ms) : 1456, 1505
. : milestone, 1481,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~ff9bbf2b31, baseline=1.43.0-SNAPSHOT~6181783bd1
dateFormat X
axisFormat %s
section baseline
no_agent (15.493 s) : 15493000, 15493000
. : milestone, 15493000,
appsec (15.144 s) : 15144000, 15144000
. : milestone, 15144000,
iast (18.635 s) : 18635000, 18635000
. : milestone, 18635000,
iast_GLOBAL (18.09 s) : 18090000, 18090000
. : milestone, 18090000,
profiling (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
tracing (15.173 s) : 15173000, 15173000
. : milestone, 15173000,
section candidate
no_agent (15.808 s) : 15808000, 15808000
. : milestone, 15808000,
appsec (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
iast (18.755 s) : 18755000, 18755000
. : milestone, 18755000,
iast_GLOBAL (18.24 s) : 18240000, 18240000
. : milestone, 18240000,
profiling (15.21 s) : 15210000, 15210000
. : milestone, 15210000,
tracing (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~ff9bbf2b31, baseline=1.43.0-SNAPSHOT~6181783bd1
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.34 ms) : 2299, 2381
. : milestone, 2340,
iast (2.071 ms) : 2019, 2122
. : milestone, 2071,
iast_GLOBAL (2.134 ms) : 2081, 2188
. : milestone, 2134,
profiling (1.936 ms) : 1895, 1977
. : milestone, 1936,
tracing (1.921 ms) : 1881, 1961
. : milestone, 1921,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.345 ms) : 2303, 2387
. : milestone, 2345,
iast (2.085 ms) : 2032, 2138
. : milestone, 2085,
iast_GLOBAL (2.13 ms) : 2077, 2183
. : milestone, 2130,
profiling (1.944 ms) : 1901, 1987
. : milestone, 1944,
tracing (1.928 ms) : 1888, 1968
. : milestone, 1928,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]