-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Grizzly instrumentation to check active span instead of scope #7982
Draft
mcculls
wants to merge
1
commit into
master
Choose a base branch
from
mcculls/grizzly-prefer-active-span-check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
added
inst: others
All other instrumentations
tag: no release notes
Changes to exclude from release notes
type: refactoring
labels
Nov 20, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~207c0c2037, baseline=1.43.0-SNAPSHOT~e5aa8fa019
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089112
Total [baseline] (8.655 s) : 0, 8655239
Agent [candidate] (1.092 s) : 0, 1091536
Total [candidate] (8.662 s) : 0, 8661733
section iast
Agent [baseline] (1.216 s) : 0, 1215761
Total [baseline] (9.218 s) : 0, 9218231
Agent [candidate] (1.218 s) : 0, 1218483
Total [candidate] (9.187 s) : 0, 9187043
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.225 s) : 0, 1224642
Total [baseline] (9.186 s) : 0, 9186009
Agent [candidate] (1.215 s) : 0, 1215406
Total [candidate] (9.152 s) : 0, 9152374
section iast_TELEMETRY_OFF
Agent [baseline] (1.223 s) : 0, 1222823
Total [baseline] (9.218 s) : 0, 9218326
Agent [candidate] (1.211 s) : 0, 1211108
Total [candidate] (9.204 s) : 0, 9203754
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~207c0c2037, baseline=1.43.0-SNAPSHOT~e5aa8fa019
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.355 ms) : 0, 693355
BytebuddyAgent [candidate] (692.749 ms) : 0, 692749
GlobalTracer [baseline] (317.914 ms) : 0, 317914
GlobalTracer [candidate] (318.829 ms) : 0, 318829
AppSec [baseline] (54.779 ms) : 0, 54779
AppSec [candidate] (54.835 ms) : 0, 54835
Remote Config [baseline] (690.524 µs) : 0, 691
Remote Config [candidate] (693.323 µs) : 0, 693
Telemetry [baseline] (8.641 ms) : 0, 8641
Telemetry [candidate] (10.719 ms) : 0, 10719
section iast
BytebuddyAgent [baseline] (808.875 ms) : 0, 808875
BytebuddyAgent [candidate] (811.322 ms) : 0, 811322
GlobalTracer [baseline] (306.347 ms) : 0, 306347
GlobalTracer [candidate] (306.996 ms) : 0, 306996
AppSec [baseline] (57.952 ms) : 0, 57952
AppSec [candidate] (57.793 ms) : 0, 57793
IAST [baseline] (20.83 ms) : 0, 20830
IAST [candidate] (20.602 ms) : 0, 20602
Remote Config [baseline] (608.768 µs) : 0, 609
Remote Config [candidate] (607.485 µs) : 0, 607
Telemetry [baseline] (7.468 ms) : 0, 7468
Telemetry [candidate] (7.387 ms) : 0, 7387
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (814.349 ms) : 0, 814349
BytebuddyAgent [candidate] (808.369 ms) : 0, 808369
GlobalTracer [baseline] (308.742 ms) : 0, 308742
GlobalTracer [candidate] (306.544 ms) : 0, 306544
AppSec [baseline] (56.715 ms) : 0, 56715
AppSec [candidate] (58.008 ms) : 0, 58008
IAST [baseline] (22.819 ms) : 0, 22819
IAST [candidate] (20.655 ms) : 0, 20655
Remote Config [baseline] (624.572 µs) : 0, 625
Remote Config [candidate] (618.497 µs) : 0, 618
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.504 ms) : 0, 7504
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (813.492 ms) : 0, 813492
BytebuddyAgent [candidate] (805.494 ms) : 0, 805494
GlobalTracer [baseline] (308.205 ms) : 0, 308205
GlobalTracer [candidate] (305.748 ms) : 0, 305748
AppSec [baseline] (58.705 ms) : 0, 58705
AppSec [candidate] (57.988 ms) : 0, 57988
IAST [baseline] (20.56 ms) : 0, 20560
IAST [candidate] (20.255 ms) : 0, 20255
Remote Config [baseline] (622.094 µs) : 0, 622
Remote Config [candidate] (633.36 µs) : 0, 633
Telemetry [baseline] (7.441 ms) : 0, 7441
Telemetry [candidate] (7.311 ms) : 0, 7311
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~207c0c2037, baseline=1.43.0-SNAPSHOT~e5aa8fa019
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092142
Total [baseline] (10.496 s) : 0, 10495584
Agent [candidate] (1.087 s) : 0, 1086628
Total [candidate] (10.592 s) : 0, 10592235
section appsec
Agent [baseline] (1.226 s) : 0, 1226045
Total [baseline] (10.682 s) : 0, 10682299
Agent [candidate] (1.228 s) : 0, 1227716
Total [candidate] (10.719 s) : 0, 10719383
section iast
Agent [baseline] (1.216 s) : 0, 1215638
Total [baseline] (10.969 s) : 0, 10969136
Agent [candidate] (1.217 s) : 0, 1216800
Total [candidate] (10.981 s) : 0, 10980797
section profiling
Agent [baseline] (1.296 s) : 0, 1296254
Total [baseline] (10.8 s) : 0, 10799979
Agent [candidate] (1.294 s) : 0, 1294164
Total [candidate] (10.848 s) : 0, 10847925
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~207c0c2037, baseline=1.43.0-SNAPSHOT~e5aa8fa019
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.612 ms) : 0, 695612
BytebuddyAgent [candidate] (690.927 ms) : 0, 690927
GlobalTracer [baseline] (318.69 ms) : 0, 318690
GlobalTracer [candidate] (316.671 ms) : 0, 316671
AppSec [baseline] (54.847 ms) : 0, 54847
AppSec [candidate] (54.464 ms) : 0, 54464
Remote Config [baseline] (686.934 µs) : 0, 687
Remote Config [candidate] (682.432 µs) : 0, 682
Telemetry [baseline] (8.538 ms) : 0, 8538
Telemetry [candidate] (10.19 ms) : 0, 10190
section appsec
BytebuddyAgent [baseline] (712.173 ms) : 0, 712173
BytebuddyAgent [candidate] (712.252 ms) : 0, 712252
GlobalTracer [baseline] (314.248 ms) : 0, 314248
GlobalTracer [candidate] (315.29 ms) : 0, 315290
AppSec [baseline] (166.528 ms) : 0, 166528
AppSec [candidate] (167.15 ms) : 0, 167150
Remote Config [baseline] (638.121 µs) : 0, 638
Remote Config [candidate] (656.143 µs) : 0, 656
Telemetry [baseline] (8.235 ms) : 0, 8235
Telemetry [candidate] (8.602 ms) : 0, 8602
IAST [baseline] (21.029 ms) : 0, 21029
IAST [candidate] (19.969 ms) : 0, 19969
section iast
BytebuddyAgent [baseline] (808.523 ms) : 0, 808523
BytebuddyAgent [candidate] (809.456 ms) : 0, 809456
GlobalTracer [baseline] (306.475 ms) : 0, 306475
GlobalTracer [candidate] (306.446 ms) : 0, 306446
AppSec [baseline] (56.305 ms) : 0, 56305
AppSec [candidate] (56.578 ms) : 0, 56578
Remote Config [baseline] (610.903 µs) : 0, 611
Remote Config [candidate] (612.02 µs) : 0, 612
Telemetry [baseline] (7.418 ms) : 0, 7418
Telemetry [candidate] (7.51 ms) : 0, 7510
IAST [baseline] (22.609 ms) : 0, 22609
IAST [candidate] (22.51 ms) : 0, 22510
section profiling
ProfilingAgent [baseline] (92.592 ms) : 0, 92592
ProfilingAgent [candidate] (94.46 ms) : 0, 94460
BytebuddyAgent [baseline] (692.492 ms) : 0, 692492
BytebuddyAgent [candidate] (690.524 ms) : 0, 690524
GlobalTracer [baseline] (403.517 ms) : 0, 403517
GlobalTracer [candidate] (402.021 ms) : 0, 402021
AppSec [baseline] (55.579 ms) : 0, 55579
AppSec [candidate] (55.693 ms) : 0, 55693
Remote Config [baseline] (685.32 µs) : 0, 685
Remote Config [candidate] (693.047 µs) : 0, 693
Telemetry [baseline] (12.126 ms) : 0, 12126
Telemetry [candidate] (11.547 ms) : 0, 11547
Profiling [baseline] (92.615 ms) : 0, 92615
Profiling [candidate] (94.483 ms) : 0, 94483
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~207c0c2037, baseline=1.43.0-SNAPSHOT~e5aa8fa019
dateFormat X
axisFormat %s
section baseline
no_agent (1.347 ms) : 1326, 1367
. : milestone, 1347,
appsec (1.778 ms) : 1754, 1802
. : milestone, 1778,
appsec_no_iast (1.747 ms) : 1721, 1774
. : milestone, 1747,
iast (1.492 ms) : 1469, 1514
. : milestone, 1492,
profiling (1.484 ms) : 1461, 1507
. : milestone, 1484,
tracing (1.469 ms) : 1444, 1494
. : milestone, 1469,
section candidate
no_agent (1.352 ms) : 1333, 1371
. : milestone, 1352,
appsec (1.717 ms) : 1693, 1741
. : milestone, 1717,
appsec_no_iast (1.751 ms) : 1726, 1775
. : milestone, 1751,
iast (1.507 ms) : 1485, 1529
. : milestone, 1507,
profiling (1.509 ms) : 1485, 1534
. : milestone, 1509,
tracing (1.479 ms) : 1453, 1504
. : milestone, 1479,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~207c0c2037, baseline=1.43.0-SNAPSHOT~e5aa8fa019
dateFormat X
axisFormat %s
section baseline
no_agent (369.301 µs) : 349, 390
. : milestone, 369,
iast (483.89 µs) : 463, 505
. : milestone, 484,
iast_FULL (648.967 µs) : 627, 671
. : milestone, 649,
iast_GLOBAL (511.862 µs) : 491, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (490.096 µs) : 469, 511
. : milestone, 490,
iast_INACTIVE (448.693 µs) : 428, 469
. : milestone, 449,
iast_TELEMETRY_OFF (478.119 µs) : 456, 500
. : milestone, 478,
tracing (443.434 µs) : 421, 466
. : milestone, 443,
section candidate
no_agent (372.236 µs) : 352, 393
. : milestone, 372,
iast (491.069 µs) : 470, 513
. : milestone, 491,
iast_FULL (645.304 µs) : 624, 667
. : milestone, 645,
iast_GLOBAL (509.649 µs) : 488, 531
. : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (484.827 µs) : 464, 506
. : milestone, 485,
iast_INACTIVE (448.127 µs) : 427, 469
. : milestone, 448,
iast_TELEMETRY_OFF (478.715 µs) : 457, 500
. : milestone, 479,
tracing (441.192 µs) : 421, 462
. : milestone, 441,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~207c0c2037, baseline=1.43.0-SNAPSHOT~e5aa8fa019
dateFormat X
axisFormat %s
section baseline
no_agent (14.782 s) : 14782000, 14782000
. : milestone, 14782000,
appsec (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
iast (18.371 s) : 18371000, 18371000
. : milestone, 18371000,
iast_GLOBAL (17.995 s) : 17995000, 17995000
. : milestone, 17995000,
profiling (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
tracing (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
section candidate
no_agent (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
appsec (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
iast (18.552 s) : 18552000, 18552000
. : milestone, 18552000,
iast_GLOBAL (17.995 s) : 17995000, 17995000
. : milestone, 17995000,
profiling (15.163 s) : 15163000, 15163000
. : milestone, 15163000,
tracing (14.889 s) : 14889000, 14889000
. : milestone, 14889000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~207c0c2037, baseline=1.43.0-SNAPSHOT~e5aa8fa019
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.313 ms) : 2272, 2354
. : milestone, 2313,
iast (2.06 ms) : 2008, 2112
. : milestone, 2060,
iast_GLOBAL (2.125 ms) : 2073, 2178
. : milestone, 2125,
profiling (1.944 ms) : 1902, 1987
. : milestone, 1944,
tracing (1.909 ms) : 1869, 1948
. : milestone, 1909,
section candidate
no_agent (1.463 ms) : 1451, 1474
. : milestone, 1463,
appsec (2.329 ms) : 2288, 2370
. : milestone, 2329,
iast (2.073 ms) : 2021, 2125
. : milestone, 2073,
iast_GLOBAL (2.11 ms) : 2058, 2162
. : milestone, 2110,
profiling (1.932 ms) : 1891, 1974
. : milestone, 1932,
tracing (1.915 ms) : 1876, 1955
. : milestone, 1915,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: others
All other instrumentations
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]