Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify validity of extracted SpanID for compound header extraction span links #8003

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Verify validity of extracted SpanID for compound header extraction span links #8003

wants to merge 7 commits into from
+6 −4

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Nov 22, 2024 •
edited
Loading

What Does This Do

Adds a check to ensure that Span Links are only created in compound header extraction when the SpanID is valid.

Motivation

This system-tests PR introduces a test to ensure that all libraries only create span links in distributed tracing header extraction when the SpanID is valid. This PR aims to implement this check in dd-trace-java and pass the test referenced.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mhlidd mhlidd changed the title verify extracted SpanID is valid before creating span link Verify validity of extracted SpanID for compound header extraction span links Nov 22, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 22, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/check_valid_span_id
git_commit_date 1732656091 1732661816
git_commit_sha 9eaf5a0 1074154
release_version 1.44.0-SNAPSHOT~9eaf5a01bb 1.43.0-SNAPSHOT~1074154aca
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732664422 1732664422
ci_job_id 721554500 721554500
ci_pipeline_id 50030904 50030904
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~1074154aca, baseline=1.44.0-SNAPSHOT~9eaf5a01bb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1099671
Total [baseline] (10.459 s) : 0, 10459364
Agent [candidate] (1.089 s) : 0, 1088814
Total [candidate] (10.449 s) : 0, 10449167
section appsec
Agent [baseline] (1.228 s) : 0, 1228035
Total [baseline] (10.745 s) : 0, 10745487
Agent [candidate] (1.222 s) : 0, 1221816
Total [candidate] (10.708 s) : 0, 10707653
section iast
Agent [baseline] (1.215 s) : 0, 1214928
Total [baseline] (10.933 s) : 0, 10933131
Agent [candidate] (1.224 s) : 0, 1223955
Total [candidate] (10.925 s) : 0, 10924750
section profiling
Agent [baseline] (1.314 s) : 0, 1313858
Total [baseline] (10.802 s) : 0, 10802348
Agent [candidate] (1.317 s) : 0, 1316592
Total [candidate] (10.771 s) : 0, 10771162
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.1 s -
Agent appsec 1.228 s 128.365 ms (11.7%)
Agent iast 1.215 s 115.257 ms (10.5%)
Agent profiling 1.314 s 214.187 ms (19.5%)
Total tracing 10.459 s -
Total appsec 10.745 s 286.123 ms (2.7%)
Total iast 10.933 s 473.767 ms (4.5%)
Total profiling 10.802 s 342.984 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent appsec 1.222 s 133.002 ms (12.2%)
Agent iast 1.224 s 135.141 ms (12.4%)
Agent profiling 1.317 s 227.778 ms (20.9%)
Total tracing 10.449 s -
Total appsec 10.708 s 258.486 ms (2.5%)
Total iast 10.925 s 475.583 ms (4.6%)
Total profiling 10.771 s 321.995 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~1074154aca, baseline=1.44.0-SNAPSHOT~9eaf5a01bb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.691 ms) : 0, 697691
BytebuddyAgent [candidate] (690.809 ms) : 0, 690809
GlobalTracer [baseline] (319.619 ms) : 0, 319619
GlobalTracer [candidate] (317.626 ms) : 0, 317626
AppSec [baseline] (55.069 ms) : 0, 55069
AppSec [candidate] (54.692 ms) : 0, 54692
Remote Config [baseline] (683.485 µs) : 0, 683
Remote Config [candidate] (682.709 µs) : 0, 683
Telemetry [baseline] (12.816 ms) : 0, 12816
Telemetry [candidate] (11.28 ms) : 0, 11280
section appsec
BytebuddyAgent [baseline] (712.469 ms) : 0, 712469
BytebuddyAgent [candidate] (708.486 ms) : 0, 708486
GlobalTracer [baseline] (315.519 ms) : 0, 315519
GlobalTracer [candidate] (314.926 ms) : 0, 314926
AppSec [baseline] (167.654 ms) : 0, 167654
AppSec [candidate] (166.073 ms) : 0, 166073
IAST [baseline] (19.736 ms) : 0, 19736
IAST [candidate] (20.37 ms) : 0, 20370
Remote Config [baseline] (639.02 µs) : 0, 639
Remote Config [candidate] (642.457 µs) : 0, 642
Telemetry [baseline] (8.161 ms) : 0, 8161
Telemetry [candidate] (7.832 ms) : 0, 7832
section iast
BytebuddyAgent [baseline] (809.632 ms) : 0, 809632
BytebuddyAgent [candidate] (814.194 ms) : 0, 814194
GlobalTracer [baseline] (305.535 ms) : 0, 305535
GlobalTracer [candidate] (308.8 ms) : 0, 308800
AppSec [baseline] (57.473 ms) : 0, 57473
AppSec [candidate] (56.654 ms) : 0, 56654
IAST [baseline] (20.578 ms) : 0, 20578
IAST [candidate] (22.403 ms) : 0, 22403
Remote Config [baseline] (613.785 µs) : 0, 614
Remote Config [candidate] (625.266 µs) : 0, 625
Telemetry [baseline] (7.425 ms) : 0, 7425
Telemetry [candidate] (7.482 ms) : 0, 7482
section profiling
BytebuddyAgent [baseline] (686.561 ms) : 0, 686561
BytebuddyAgent [candidate] (686.398 ms) : 0, 686398
GlobalTracer [baseline] (433.693 ms) : 0, 433693
GlobalTracer [candidate] (435.522 ms) : 0, 435522
AppSec [baseline] (53.648 ms) : 0, 53648
AppSec [candidate] (53.777 ms) : 0, 53777
Remote Config [baseline] (656.244 µs) : 0, 656
Remote Config [candidate] (664.309 µs) : 0, 664
Telemetry [baseline] (7.685 ms) : 0, 7685
Telemetry [candidate] (7.75 ms) : 0, 7750
ProfilingAgent [baseline] (92.634 ms) : 0, 92634
ProfilingAgent [candidate] (93.401 ms) : 0, 93401
Profiling [baseline] (92.657 ms) : 0, 92657
Profiling [candidate] (93.424 ms) : 0, 93424
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~1074154aca, baseline=1.44.0-SNAPSHOT~9eaf5a01bb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1100867
Total [baseline] (8.665 s) : 0, 8664840
Agent [candidate] (1.092 s) : 0, 1091714
Total [candidate] (8.663 s) : 0, 8663022
section iast
Agent [baseline] (1.224 s) : 0, 1224266
Total [baseline] (9.188 s) : 0, 9187544
Agent [candidate] (1.221 s) : 0, 1221256
Total [candidate] (9.216 s) : 0, 9215564
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.214 s) : 0, 1213531
Total [baseline] (9.162 s) : 0, 9161879
Agent [candidate] (1.218 s) : 0, 1218331
Total [candidate] (9.207 s) : 0, 9207173
section iast_TELEMETRY_OFF
Agent [baseline] (1.215 s) : 0, 1214913
Total [baseline] (9.161 s) : 0, 9161418
Agent [candidate] (1.213 s) : 0, 1212735
Total [candidate] (9.172 s) : 0, 9172389
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.101 s -
Agent iast 1.224 s 123.399 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.214 s 112.664 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.215 s 114.045 ms (10.4%)
Total tracing 8.665 s -
Total iast 9.188 s 522.704 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.162 s 497.039 ms (5.7%)
Total iast_TELEMETRY_OFF 9.161 s 496.578 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.221 s 129.542 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.218 s 126.617 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.213 s 121.021 ms (11.1%)
Total tracing 8.663 s -
Total iast 9.216 s 552.542 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.207 s 544.151 ms (6.3%)
Total iast_TELEMETRY_OFF 9.172 s 509.367 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~1074154aca, baseline=1.44.0-SNAPSHOT~9eaf5a01bb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (700.562 ms) : 0, 700562
BytebuddyAgent [candidate] (693.749 ms) : 0, 693749
GlobalTracer [baseline] (318.938 ms) : 0, 318938
GlobalTracer [candidate] (318.427 ms) : 0, 318427
AppSec [baseline] (54.869 ms) : 0, 54869
AppSec [candidate] (55.136 ms) : 0, 55136
Remote Config [baseline] (676.611 µs) : 0, 677
Remote Config [candidate] (686.8 µs) : 0, 687
Telemetry [baseline] (11.938 ms) : 0, 11938
Telemetry [candidate] (9.935 ms) : 0, 9935
section iast
BytebuddyAgent [baseline] (815.707 ms) : 0, 815707
BytebuddyAgent [candidate] (811.858 ms) : 0, 811858
GlobalTracer [baseline] (307.115 ms) : 0, 307115
GlobalTracer [candidate] (308.937 ms) : 0, 308937
AppSec [baseline] (56.717 ms) : 0, 56717
AppSec [candidate] (57.076 ms) : 0, 57076
Remote Config [baseline] (632.734 µs) : 0, 633
Remote Config [candidate] (629.428 µs) : 0, 629
Telemetry [baseline] (7.589 ms) : 0, 7589
Telemetry [candidate] (7.41 ms) : 0, 7410
IAST [baseline] (22.708 ms) : 0, 22708
IAST [candidate] (21.58 ms) : 0, 21580
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (808.193 ms) : 0, 808193
BytebuddyAgent [candidate] (809.1 ms) : 0, 809100
GlobalTracer [baseline] (305.111 ms) : 0, 305111
GlobalTracer [candidate] (308.464 ms) : 0, 308464
AppSec [baseline] (57.021 ms) : 0, 57021
AppSec [candidate] (57.848 ms) : 0, 57848
Remote Config [baseline] (657.805 µs) : 0, 658
Remote Config [candidate] (623.624 µs) : 0, 624
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (7.567 ms) : 0, 7567
IAST [baseline] (21.465 ms) : 0, 21465
IAST [candidate] (20.982 ms) : 0, 20982
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (809.099 ms) : 0, 809099
BytebuddyAgent [candidate] (805.527 ms) : 0, 805527
GlobalTracer [baseline] (305.985 ms) : 0, 305985
GlobalTracer [candidate] (307.023 ms) : 0, 307023
AppSec [baseline] (57.187 ms) : 0, 57187
AppSec [candidate] (57.931 ms) : 0, 57931
Remote Config [baseline] (605.187 µs) : 0, 605
Remote Config [candidate] (628.237 µs) : 0, 628
Telemetry [baseline] (7.342 ms) : 0, 7342
Telemetry [candidate] (7.397 ms) : 0, 7397
IAST [baseline] (20.976 ms) : 0, 20976
IAST [candidate] (20.502 ms) : 0, 20502
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-26T23:10:25 2024-11-26T23:17:23
git_branch master mhlidd/check_valid_span_id
git_commit_date 1732656091 1732661816
git_commit_sha 9eaf5a0 1074154
release_version 1.44.0-SNAPSHOT~9eaf5a01bb 1.43.0-SNAPSHOT~1074154aca
start_time 2024-11-26T23:10:12 2024-11-26T23:17:09
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732663394 1732663394
ci_job_id 721554501 721554501
ci_pipeline_id 50030904 50030904
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~1074154aca, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.463 µs) : 348, 389
.   : milestone, 368,
iast (490.107 µs) : 468, 512
.   : milestone, 490,
iast_FULL (647.7 µs) : 626, 669
.   : milestone, 648,
iast_GLOBAL (513.91 µs) : 493, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (501.994 µs) : 480, 524
.   : milestone, 502,
iast_INACTIVE (444.646 µs) : 424, 465
.   : milestone, 445,
iast_TELEMETRY_OFF (478.476 µs) : 457, 500
.   : milestone, 478,
tracing (445.009 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (370.339 µs) : 349, 391
.   : milestone, 370,
iast (482.693 µs) : 461, 504
.   : milestone, 483,
iast_FULL (649.491 µs) : 628, 671
.   : milestone, 649,
iast_GLOBAL (518.937 µs) : 496, 542
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (489.464 µs) : 468, 511
.   : milestone, 489,
iast_INACTIVE (448.56 µs) : 427, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (477.355 µs) : 456, 499
.   : milestone, 477,
tracing (451.476 µs) : 430, 473
.   : milestone, 451,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.463 µs [348.293 µs, 388.633 µs] -
iast 490.107 µs [468.162 µs, 512.052 µs] 121.644 µs (33.0%)
iast_FULL 647.7 µs [626.117 µs, 669.283 µs] 279.237 µs (75.8%)
iast_GLOBAL 513.91 µs [492.775 µs, 535.044 µs] 145.447 µs (39.5%)
iast_HARDCODED_SECRET_DISABLED 501.994 µs [480.441 µs, 523.546 µs] 133.531 µs (36.2%)
iast_INACTIVE 444.646 µs [423.842 µs, 465.451 µs] 76.183 µs (20.7%)
iast_TELEMETRY_OFF 478.476 µs [456.84 µs, 500.113 µs] 110.014 µs (29.9%)
tracing 445.009 µs [424.259 µs, 465.759 µs] 76.546 µs (20.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.339 µs [349.468 µs, 391.21 µs] -
iast 482.693 µs [461.48 µs, 503.906 µs] 112.354 µs (30.3%)
iast_FULL 649.491 µs [628.047 µs, 670.936 µs] 279.152 µs (75.4%)
iast_GLOBAL 518.937 µs [496.177 µs, 541.697 µs] 148.598 µs (40.1%)
iast_HARDCODED_SECRET_DISABLED 489.464 µs [468.18 µs, 510.749 µs] 119.125 µs (32.2%)
iast_INACTIVE 448.56 µs [427.214 µs, 469.905 µs] 78.221 µs (21.1%)
iast_TELEMETRY_OFF 477.355 µs [455.831 µs, 498.88 µs] 107.016 µs (28.9%)
tracing 451.476 µs [430.356 µs, 472.596 µs] 81.137 µs (21.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~1074154aca, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1325, 1364
.   : milestone, 1345,
appsec (1.732 ms) : 1707, 1757
.   : milestone, 1732,
appsec_no_iast (1.726 ms) : 1701, 1751
.   : milestone, 1726,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.527 ms) : 1502, 1551
.   : milestone, 1527,
tracing (1.496 ms) : 1470, 1522
.   : milestone, 1496,
section candidate
no_agent (1.358 ms) : 1339, 1377
.   : milestone, 1358,
appsec (1.741 ms) : 1717, 1765
.   : milestone, 1741,
appsec_no_iast (1.75 ms) : 1726, 1774
.   : milestone, 1750,
iast (1.5 ms) : 1478, 1523
.   : milestone, 1500,
profiling (1.478 ms) : 1455, 1501
.   : milestone, 1478,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.325 ms, 1.364 ms] -
appsec 1.732 ms [1.707 ms, 1.757 ms] 387.255 µs (28.8%)
appsec_no_iast 1.726 ms [1.701 ms, 1.751 ms] 380.998 µs (28.3%)
iast 1.491 ms [1.468 ms, 1.514 ms] 146.183 µs (10.9%)
profiling 1.527 ms [1.502 ms, 1.551 ms] 181.799 µs (13.5%)
tracing 1.496 ms [1.47 ms, 1.522 ms] 151.161 µs (11.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.339 ms, 1.377 ms] -
appsec 1.741 ms [1.717 ms, 1.765 ms] 382.906 µs (28.2%)
appsec_no_iast 1.75 ms [1.726 ms, 1.774 ms] 392.39 µs (28.9%)
iast 1.5 ms [1.478 ms, 1.523 ms] 142.305 µs (10.5%)
profiling 1.478 ms [1.455 ms, 1.501 ms] 120.089 µs (8.8%)
tracing 1.471 ms [1.447 ms, 1.495 ms] 113.176 µs (8.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/check_valid_span_id
git_commit_date 1732656091 1732661816
git_commit_sha 9eaf5a0 1074154
release_version 1.44.0-SNAPSHOT~9eaf5a01bb 1.43.0-SNAPSHOT~1074154aca
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732663963 1732663963
ci_job_id 721554502 721554502
ci_pipeline_id 50030904 50030904
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~1074154aca, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.262 s) : 15262000, 15262000
.   : milestone, 15262000,
appsec (15.038 s) : 15038000, 15038000
.   : milestone, 15038000,
iast (18.393 s) : 18393000, 18393000
.   : milestone, 18393000,
iast_GLOBAL (17.76 s) : 17760000, 17760000
.   : milestone, 17760000,
profiling (14.789 s) : 14789000, 14789000
.   : milestone, 14789000,
tracing (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
section candidate
no_agent (15.326 s) : 15326000, 15326000
.   : milestone, 15326000,
appsec (14.769 s) : 14769000, 14769000
.   : milestone, 14769000,
iast (18.609 s) : 18609000, 18609000
.   : milestone, 18609000,
iast_GLOBAL (18.087 s) : 18087000, 18087000
.   : milestone, 18087000,
profiling (14.839 s) : 14839000, 14839000
.   : milestone, 14839000,
tracing (15.093 s) : 15093000, 15093000
.   : milestone, 15093000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.262 s [15.262 s, 15.262 s] -
appsec 15.038 s [15.038 s, 15.038 s] -224.0 ms (-1.5%)
iast 18.393 s [18.393 s, 18.393 s] 3.131 s (20.5%)
iast_GLOBAL 17.76 s [17.76 s, 17.76 s] 2.498 s (16.4%)
profiling 14.789 s [14.789 s, 14.789 s] -473.0 ms (-3.1%)
tracing 15.037 s [15.037 s, 15.037 s] -225.0 ms (-1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.326 s [15.326 s, 15.326 s] -
appsec 14.769 s [14.769 s, 14.769 s] -557.0 ms (-3.6%)
iast 18.609 s [18.609 s, 18.609 s] 3.283 s (21.4%)
iast_GLOBAL 18.087 s [18.087 s, 18.087 s] 2.761 s (18.0%)
profiling 14.839 s [14.839 s, 14.839 s] -487.0 ms (-3.2%)
tracing 15.093 s [15.093 s, 15.093 s] -233.0 ms (-1.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~1074154aca, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.341 ms) : 2299, 2383
.   : milestone, 2341,
iast (2.072 ms) : 2020, 2125
.   : milestone, 2072,
iast_GLOBAL (2.127 ms) : 2073, 2180
.   : milestone, 2127,
profiling (1.969 ms) : 1926, 2012
.   : milestone, 1969,
tracing (1.93 ms) : 1889, 1971
.   : milestone, 1930,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.34 ms) : 2298, 2381
.   : milestone, 2340,
iast (2.087 ms) : 2035, 2140
.   : milestone, 2087,
iast_GLOBAL (2.135 ms) : 2082, 2188
.   : milestone, 2135,
profiling (2.456 ms) : 2266, 2645
.   : milestone, 2456,
tracing (1.934 ms) : 1893, 1976
.   : milestone, 1934,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.341 ms [2.299 ms, 2.383 ms] 873.699 µs (59.5%)
iast 2.072 ms [2.02 ms, 2.125 ms] 604.87 µs (41.2%)
iast_GLOBAL 2.127 ms [2.073 ms, 2.18 ms] 659.399 µs (44.9%)
profiling 1.969 ms [1.926 ms, 2.012 ms] 501.846 µs (34.2%)
tracing 1.93 ms [1.889 ms, 1.971 ms] 462.69 µs (31.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.34 ms [2.298 ms, 2.381 ms] 871.693 µs (59.4%)
iast 2.087 ms [2.035 ms, 2.14 ms] 619.355 µs (42.2%)
iast_GLOBAL 2.135 ms [2.082 ms, 2.188 ms] 667.213 µs (45.5%)
profiling 2.456 ms [2.266 ms, 2.645 ms] 987.844 µs (67.3%)
tracing 1.934 ms [1.893 ms, 1.976 ms] 466.387 µs (31.8%)

PerfectSlayer
PerfectSlayer reviewed Nov 25, 2024
View reviewed changes
dd-trace-core/src/main/java/datadog/trace/core/propagation/HttpCodec.java Outdated
Comment on lines 242 to 243
} else if (extractedContext.getSpanId()
!= 0) { // Check that SpanID of secondary extracted context is valid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather check that ContextInterpreter implementations are properly implemented by returning only fullContext to true when context is complete (so it will be an ExtractedContext) rather than adding tests on every access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhlidd @PerfectSlayer