-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CI job onboarding_tests_k8s_injection to include Data Jobs Monitoring's test case with k8s injection. #8022
Draft
yiliangzhou
wants to merge
1
commit into
master
Choose a base branch
from
liangzhou.yi/include-djm-system-test-in-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overing k8s injection used by Data Jobs Monitoring
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~3c2b5f0d53, baseline=1.44.0-SNAPSHOT~983bf0f97c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1090500
Total [baseline] (8.689 s) : 0, 8689006
Agent [candidate] (1.092 s) : 0, 1092347
Total [candidate] (8.654 s) : 0, 8654328
section iast
Agent [baseline] (1.225 s) : 0, 1225495
Total [baseline] (9.21 s) : 0, 9210050
Agent [candidate] (1.233 s) : 0, 1232773
Total [candidate] (9.174 s) : 0, 9174430
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1215237
Total [baseline] (9.189 s) : 0, 9188879
Agent [candidate] (1.217 s) : 0, 1217125
Total [candidate] (9.136 s) : 0, 9135869
section iast_TELEMETRY_OFF
Agent [baseline] (1.213 s) : 0, 1213184
Total [baseline] (9.156 s) : 0, 9155660
Agent [candidate] (1.222 s) : 0, 1221944
Total [candidate] (9.219 s) : 0, 9219462
gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~3c2b5f0d53, baseline=1.44.0-SNAPSHOT~983bf0f97c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.387 ms) : 0, 693387
BytebuddyAgent [candidate] (694.746 ms) : 0, 694746
GlobalTracer [baseline] (317.464 ms) : 0, 317464
GlobalTracer [candidate] (317.687 ms) : 0, 317687
AppSec [baseline] (54.497 ms) : 0, 54497
AppSec [candidate] (54.812 ms) : 0, 54812
Remote Config [baseline] (671.085 µs) : 0, 671
Remote Config [candidate] (678.582 µs) : 0, 679
Telemetry [baseline] (10.776 ms) : 0, 10776
Telemetry [candidate] (10.733 ms) : 0, 10733
section iast
BytebuddyAgent [baseline] (816.788 ms) : 0, 816788
BytebuddyAgent [candidate] (822.48 ms) : 0, 822480
GlobalTracer [baseline] (307.534 ms) : 0, 307534
GlobalTracer [candidate] (309.296 ms) : 0, 309296
AppSec [baseline] (55.982 ms) : 0, 55982
AppSec [candidate] (57.323 ms) : 0, 57323
IAST [baseline] (23.265 ms) : 0, 23265
IAST [candidate] (21.58 ms) : 0, 21580
Remote Config [baseline] (613.849 µs) : 0, 614
Remote Config [candidate] (631.033 µs) : 0, 631
Telemetry [baseline] (7.537 ms) : 0, 7537
Telemetry [candidate] (7.518 ms) : 0, 7518
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.682 ms) : 0, 809682
BytebuddyAgent [candidate] (810.477 ms) : 0, 810477
GlobalTracer [baseline] (305.024 ms) : 0, 305024
GlobalTracer [candidate] (306.13 ms) : 0, 306130
AppSec [baseline] (57.833 ms) : 0, 57833
AppSec [candidate] (58.157 ms) : 0, 58157
IAST [baseline] (20.814 ms) : 0, 20814
IAST [candidate] (20.63 ms) : 0, 20630
Remote Config [baseline] (631.919 µs) : 0, 632
Remote Config [candidate] (617.907 µs) : 0, 618
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.433 ms) : 0, 7433
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.72 ms) : 0, 807720
BytebuddyAgent [candidate] (813.599 ms) : 0, 813599
GlobalTracer [baseline] (305.926 ms) : 0, 305926
GlobalTracer [candidate] (307.493 ms) : 0, 307493
AppSec [baseline] (57.389 ms) : 0, 57389
AppSec [candidate] (57.439 ms) : 0, 57439
IAST [baseline] (20.44 ms) : 0, 20440
IAST [candidate] (21.497 ms) : 0, 21497
Remote Config [baseline] (619.603 µs) : 0, 620
Remote Config [candidate] (625.213 µs) : 0, 625
Telemetry [baseline] (7.404 ms) : 0, 7404
Telemetry [candidate] (7.471 ms) : 0, 7471
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~3c2b5f0d53, baseline=1.44.0-SNAPSHOT~983bf0f97c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088068
Total [baseline] (10.357 s) : 0, 10357340
Agent [candidate] (1.092 s) : 0, 1092114
Total [candidate] (10.421 s) : 0, 10421499
section appsec
Agent [baseline] (1.233 s) : 0, 1232554
Total [baseline] (10.725 s) : 0, 10724698
Agent [candidate] (1.228 s) : 0, 1227722
Total [candidate] (10.696 s) : 0, 10695937
section iast
Agent [baseline] (1.226 s) : 0, 1226050
Total [baseline] (10.973 s) : 0, 10972937
Agent [candidate] (1.234 s) : 0, 1234432
Total [candidate] (10.994 s) : 0, 10993553
section profiling
Agent [baseline] (1.314 s) : 0, 1313902
Total [baseline] (10.769 s) : 0, 10768991
Agent [candidate] (1.317 s) : 0, 1316561
Total [candidate] (10.773 s) : 0, 10773263
gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~3c2b5f0d53, baseline=1.44.0-SNAPSHOT~983bf0f97c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.295 ms) : 0, 691295
BytebuddyAgent [candidate] (695.987 ms) : 0, 695987
GlobalTracer [baseline] (316.206 ms) : 0, 316206
GlobalTracer [candidate] (318.031 ms) : 0, 318031
AppSec [baseline] (54.261 ms) : 0, 54261
AppSec [candidate] (54.461 ms) : 0, 54461
Remote Config [baseline] (674.542 µs) : 0, 675
Remote Config [candidate] (678.473 µs) : 0, 678
Telemetry [baseline] (11.989 ms) : 0, 11989
Telemetry [candidate] (9.228 ms) : 0, 9228
section appsec
BytebuddyAgent [baseline] (716.453 ms) : 0, 716453
BytebuddyAgent [candidate] (713.304 ms) : 0, 713304
GlobalTracer [baseline] (315.924 ms) : 0, 315924
GlobalTracer [candidate] (314.575 ms) : 0, 314575
AppSec [baseline] (166.623 ms) : 0, 166623
AppSec [candidate] (168.629 ms) : 0, 168629
IAST [baseline] (20.975 ms) : 0, 20975
IAST [candidate] (18.84 ms) : 0, 18840
Remote Config [baseline] (659.192 µs) : 0, 659
Remote Config [candidate] (659.411 µs) : 0, 659
Telemetry [baseline] (8.663 ms) : 0, 8663
Telemetry [candidate] (7.42 ms) : 0, 7420
section iast
BytebuddyAgent [baseline] (817.935 ms) : 0, 817935
BytebuddyAgent [candidate] (823.259 ms) : 0, 823259
GlobalTracer [baseline] (307.691 ms) : 0, 307691
GlobalTracer [candidate] (309.774 ms) : 0, 309774
AppSec [baseline] (56.128 ms) : 0, 56128
AppSec [candidate] (58.206 ms) : 0, 58206
IAST [baseline] (22.418 ms) : 0, 22418
IAST [candidate] (21.005 ms) : 0, 21005
Remote Config [baseline] (604.563 µs) : 0, 605
Remote Config [candidate] (623.415 µs) : 0, 623
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.664 ms) : 0, 7664
section profiling
BytebuddyAgent [baseline] (687.631 ms) : 0, 687631
BytebuddyAgent [candidate] (690.497 ms) : 0, 690497
GlobalTracer [baseline] (432.67 ms) : 0, 432670
GlobalTracer [candidate] (431.254 ms) : 0, 431254
AppSec [baseline] (53.32 ms) : 0, 53320
AppSec [candidate] (53.74 ms) : 0, 53740
Remote Config [baseline] (648.508 µs) : 0, 649
Remote Config [candidate] (653.773 µs) : 0, 654
Telemetry [baseline] (7.746 ms) : 0, 7746
Telemetry [candidate] (7.78 ms) : 0, 7780
ProfilingAgent [baseline] (92.943 ms) : 0, 92943
ProfilingAgent [candidate] (93.476 ms) : 0, 93476
Profiling [baseline] (92.967 ms) : 0, 92967
Profiling [candidate] (93.499 ms) : 0, 93499
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~3c2b5f0d53, baseline=1.44.0-SNAPSHOT~983bf0f97c
dateFormat X
axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1381
. : milestone, 1362,
appsec (1.765 ms) : 1740, 1791
. : milestone, 1765,
appsec_no_iast (1.772 ms) : 1748, 1796
. : milestone, 1772,
iast (1.491 ms) : 1468, 1514
. : milestone, 1491,
profiling (1.531 ms) : 1506, 1556
. : milestone, 1531,
tracing (1.508 ms) : 1483, 1533
. : milestone, 1508,
section candidate
no_agent (1.36 ms) : 1340, 1379
. : milestone, 1360,
appsec (1.757 ms) : 1732, 1782
. : milestone, 1757,
appsec_no_iast (1.758 ms) : 1733, 1783
. : milestone, 1758,
iast (1.476 ms) : 1454, 1499
. : milestone, 1476,
profiling (1.518 ms) : 1495, 1541
. : milestone, 1518,
tracing (1.489 ms) : 1465, 1513
. : milestone, 1489,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~3c2b5f0d53, baseline=1.44.0-SNAPSHOT~983bf0f97c
dateFormat X
axisFormat %s
section baseline
no_agent (373.208 µs) : 354, 393
. : milestone, 373,
iast (489.182 µs) : 468, 510
. : milestone, 489,
iast_FULL (649.767 µs) : 628, 671
. : milestone, 650,
iast_GLOBAL (530.2 µs) : 507, 554
. : milestone, 530,
iast_HARDCODED_SECRET_DISABLED (490.488 µs) : 469, 512
. : milestone, 490,
iast_INACTIVE (449.177 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (480.869 µs) : 460, 502
. : milestone, 481,
tracing (448.108 µs) : 427, 469
. : milestone, 448,
section candidate
no_agent (374.883 µs) : 355, 394
. : milestone, 375,
iast (488.825 µs) : 467, 510
. : milestone, 489,
iast_FULL (655.029 µs) : 634, 677
. : milestone, 655,
iast_GLOBAL (528.84 µs) : 506, 552
. : milestone, 529,
iast_HARDCODED_SECRET_DISABLED (495.81 µs) : 474, 518
. : milestone, 496,
iast_INACTIVE (449.758 µs) : 428, 471
. : milestone, 450,
iast_TELEMETRY_OFF (481.623 µs) : 460, 503
. : milestone, 482,
tracing (449.342 µs) : 429, 470
. : milestone, 449,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~3c2b5f0d53, baseline=1.44.0-SNAPSHOT~983bf0f97c
dateFormat X
axisFormat %s
section baseline
no_agent (15.593 s) : 15593000, 15593000
. : milestone, 15593000,
appsec (15.133 s) : 15133000, 15133000
. : milestone, 15133000,
iast (18.626 s) : 18626000, 18626000
. : milestone, 18626000,
iast_GLOBAL (18.044 s) : 18044000, 18044000
. : milestone, 18044000,
profiling (15.303 s) : 15303000, 15303000
. : milestone, 15303000,
tracing (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
section candidate
no_agent (14.735 s) : 14735000, 14735000
. : milestone, 14735000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (18.736 s) : 18736000, 18736000
. : milestone, 18736000,
iast_GLOBAL (18.416 s) : 18416000, 18416000
. : milestone, 18416000,
profiling (15.795 s) : 15795000, 15795000
. : milestone, 15795000,
tracing (15.104 s) : 15104000, 15104000
. : milestone, 15104000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~3c2b5f0d53, baseline=1.44.0-SNAPSHOT~983bf0f97c
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.345 ms) : 2303, 2387
. : milestone, 2345,
iast (2.081 ms) : 2029, 2133
. : milestone, 2081,
iast_GLOBAL (2.12 ms) : 2067, 2172
. : milestone, 2120,
profiling (1.96 ms) : 1917, 2003
. : milestone, 1960,
tracing (1.921 ms) : 1881, 1961
. : milestone, 1921,
section candidate
no_agent (1.462 ms) : 1451, 1473
. : milestone, 1462,
appsec (2.332 ms) : 2291, 2373
. : milestone, 2332,
iast (2.073 ms) : 2021, 2125
. : milestone, 2073,
iast_GLOBAL (2.12 ms) : 2067, 2173
. : milestone, 2120,
profiling (1.948 ms) : 1905, 1990
. : milestone, 1948,
tracing (1.922 ms) : 1882, 1963
. : milestone, 1922,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Include k8s injection test scenario
K8S_LIBRARY_INJECTION_DJM
as part of CI jobonboarding_tests_k8s_injection
.Motivation
Data Jobs Monitoring use Single Step Instrumentation to inject java tracer in k8s in order to monitor spark application launched in k8s. The newly added test scenario
K8S_LIBRARY_INJECTION_DJM
allow us to verify the k8s injection continue to work for Data Jobs Monitoring as new tracer is being released.Additional Notes
The CI job is updated accordingly at https://github.com/DataDog/libdatadog-build/pull/51.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]