-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add span component to the telemetry metrics #12430
base: main
Are you sure you want to change the base?
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1184 Skipped, 1m 43.77s Total Time |
BenchmarksBenchmark execution time: 2025-02-19 22:32:12 Comparing candidate commit d2ed9d5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 384 metrics, 0 unstable metrics. |
@@ -281,12 +283,24 @@ def on_span_start(self, span: Span) -> None: | |||
with self._lock: | |||
trace = self._traces[span.trace_id] | |||
trace.spans.append(span) | |||
self._span_metrics["spans_created"][span._span_api] += 1 | |||
# self._span_metrics["spans_created"]["integration_name"][span._span_api] += 1 | |||
if "component" in span.get_tags(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Use: span._meta
and use the component constants
self._span_metrics["spans_created"][span._span_api] += 1 | ||
# self._span_metrics["spans_created"]["integration_name"][span._span_api] += 1 | ||
if "component" in span.get_tags(): | ||
span_component = span.get_tag("component") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace with span._meta
telemetry.telemetry_writer.add_count_metric( | ||
TELEMETRY_NAMESPACE.TRACERS, metric_name, count, tags=((tag_name, tag_value),) | ||
) | ||
for api_and_component, count in self._span_metrics[metric_name].items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try playing without batching in _queue_span_count_metrics
There's no way to tell which integrations are in use, so this PR attempts to fix that.
Checklist
Reviewer Checklist