Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span component to the telemetry metrics #12430

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Feb 19, 2025

There's no way to tell which integrations are in use, so this PR attempts to fix that.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/_trace/processor/__init__.py                                    @DataDog/apm-sdk-api-python
tests/telemetry/test_telemetry_metrics_e2e.py                           @DataDog/apm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: wantsui/add-component-telemetry
Commit report: d2ed9d5
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 1m 43.77s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 19, 2025

Benchmarks

Benchmark execution time: 2025-02-19 22:32:12

Comparing candidate commit d2ed9d5 in PR branch wantsui/add-component-telemetry with baseline commit 2f84452 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 384 metrics, 0 unstable metrics.

@@ -281,12 +283,24 @@ def on_span_start(self, span: Span) -> None:
with self._lock:
trace = self._traces[span.trace_id]
trace.spans.append(span)
self._span_metrics["spans_created"][span._span_api] += 1
# self._span_metrics["spans_created"]["integration_name"][span._span_api] += 1
if "component" in span.get_tags():
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Use: span._meta and use the component constants

self._span_metrics["spans_created"][span._span_api] += 1
# self._span_metrics["spans_created"]["integration_name"][span._span_api] += 1
if "component" in span.get_tags():
span_component = span.get_tag("component")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with span._meta

telemetry.telemetry_writer.add_count_metric(
TELEMETRY_NAMESPACE.TRACERS, metric_name, count, tags=((tag_name, tag_value),)
)
for api_and_component, count in self._span_metrics[metric_name].items():
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try playing without batching in _queue_span_count_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant