Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supported versions workflow: fix parsing and modify gem names #4294

Merged
merged 6 commits into from
Jan 18, 2025

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Jan 15, 2025

What does this PR do?

  • Update to only parse gemfile.lock files instead of also gemfile files
  • change the aws contrib to use the aws-sdk gem
  • change the http contrib to use net-http gem
  • change typos in httpx and makara: nil means we do not support the integration, infinity means we use latest

Motivation:

Addition to #4210

Change log entry

None

Additional Notes:

How to test the change?

Trigger the Generate Supported Versions workflow and look at the resulting integration_versions.md

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-01-16 22:48:17 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 15, 2025

Datadog Report

Branch report: add-gems-to-integrations
Commit report: 18de42a
Test service: dd-trace-rb

✅ 0 Failed, 22071 Passed, 1476 Skipped, 5m 15.15s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.71%. Comparing base (7e37aff) to head (18de42a).

Files with missing lines Patch % Lines
lib/datadog/tracing/contrib/aws/integration.rb 0.00% 1 Missing ⚠️
lib/datadog/tracing/contrib/http/integration.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4294   +/-   ##
=======================================
  Coverage   97.70%   97.71%           
=======================================
  Files        1358     1358           
  Lines       82502    82503    +1     
  Branches     4223     4223           
=======================================
+ Hits        80610    80617    +7     
+ Misses       1892     1886    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025

Benchmarks

Benchmark execution time: 2025-01-16 23:22:06

Comparing candidate commit 18de42a in PR branch add-gems-to-integrations with baseline commit 7e37aff in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@quinna-h quinna-h changed the title supported versions workflow: small fixes and update gems supported versions workflow: fixes and update gems Jan 15, 2025
@quinna-h quinna-h changed the title supported versions workflow: fixes and update gems supported versions workflow: fix parsing and modify gem names Jan 15, 2025
@quinna-h quinna-h marked this pull request as ready for review January 15, 2025 22:37
@quinna-h quinna-h requested review from a team as code owners January 15, 2025 22:37
@marcotc marcotc enabled auto-merge (squash) January 15, 2025 22:44
Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the changelog section in the PR description filled out.

I think that none is needed but the PR also does not say how to test it.

@quinna-h
Copy link
Contributor Author

@p-datadog Done, thanks for pointing those out.

@marcotc marcotc dismissed p-datadog’s stale review January 18, 2025 00:49

Changelog entry was added.

@marcotc marcotc merged commit 3c87889 into master Jan 18, 2025
377 of 378 checks passed
@marcotc marcotc deleted the add-gems-to-integrations branch January 18, 2025 00:49
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants