-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit CODEOWNERS and JUnit XML file paths to match #4316
Edit CODEOWNERS and JUnit XML file paths to match #4316
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 22100 Passed, 1476 Skipped, 5m 40.01s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4316 +/- ##
=======================================
Coverage 97.72% 97.73%
=======================================
Files 1365 1365
Lines 82727 82726 -1
Branches 4205 4205
=======================================
+ Hits 80846 80849 +3
+ Misses 1881 1877 -4 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-01-23 21:04:02 Comparing candidate commit db85bf7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
.
to codeowners root to correspond with XML source files
What does this PR do?
This PR removes the
/
prefix from theCODEOWNERS
paths and the./
prefix from the JUnit XML testcase source file paths.Motivation:
Currently, all of our testcase codeowner tags in CI are incorrectly marked as the default @DataDog/ruby-guild. This is because the JUnit XML testcase source file paths do not match the
CODEOWNERS
paths. By removing the prefixes above, the paths will match and testcase codeowner tags will be properly set. See this reference for how testcase codeowner tag assignments work.With proper codeowners assigned, we can better see the distribution and ownership of tests. This especially will help with identifying flaky test ownership.
Change log entry
No.
Additional Notes:
N/A
How to test the change?
This change should also show up in dashboards that filter on test codeowner tags (e.g. this dashboard under the "Test failure by codeowner" widget).