Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit CODEOWNERS and JUnit XML file paths to match #4316

Merged

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Jan 23, 2025

What does this PR do?
This PR removes the / prefix from the CODEOWNERS paths and the ./ prefix from the JUnit XML testcase source file paths.

Motivation:
Currently, all of our testcase codeowner tags in CI are incorrectly marked as the default @DataDog/ruby-guild. This is because the JUnit XML testcase source file paths do not match the CODEOWNERS paths. By removing the prefixes above, the paths will match and testcase codeowner tags will be properly set. See this reference for how testcase codeowner tag assignments work.

With proper codeowners assigned, we can better see the distribution and ownership of tests. This especially will help with identifying flaky test ownership.

Change log entry
No.

Additional Notes:
N/A

How to test the change?

  1. CircleCI build-and-test workflow
  2. any test, any run (e.g. test-3.4, run 0)
  3. "Upload JUnit reports to Datadog" (e.g. for test-3.4, run 0)
  4. Link under "Test runs report:" (e.g. for test-3.4, run 0)
  5. "Test name" corresponds to the "Test code owners" (e.g. @DataDog/asm-ruby instead of @DataDog/ruby-guild)

This change should also show up in dashboards that filter on test codeowner tags (e.g. this dashboard under the "Test failure by codeowner" widget).

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 23, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 23, 2025

Datadog Report

Branch report: sarahchen6/edit-codeowners-to-correspond-with-sourcefile
Commit report: db85bf7
Test service: dd-trace-rb

✅ 0 Failed, 22100 Passed, 1476 Skipped, 5m 40.01s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (84ca739) to head (db85bf7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4316   +/-   ##
=======================================
  Coverage   97.72%   97.73%           
=======================================
  Files        1365     1365           
  Lines       82727    82726    -1     
  Branches     4205     4205           
=======================================
+ Hits        80846    80849    +3     
+ Misses       1881     1877    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2025

Benchmarks

Benchmark execution time: 2025-01-23 21:04:02

Comparing candidate commit db85bf7 in PR branch sarahchen6/edit-codeowners-to-correspond-with-sourcefile with baseline commit 84ca739 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@sarahchen6 sarahchen6 marked this pull request as ready for review January 23, 2025 19:03
@sarahchen6 sarahchen6 requested a review from a team as a code owner January 23, 2025 19:03
.github/CODEOWNERS Outdated Show resolved Hide resolved
@sarahchen6 sarahchen6 changed the title Add . to codeowners root to correspond with XML source files Edit CODEOWNERS and JUnit XML file paths to match Jan 23, 2025
@sarahchen6 sarahchen6 merged commit a49a11c into master Jan 23, 2025
375 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/edit-codeowners-to-correspond-with-sourcefile branch January 23, 2025 21:32
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants