Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM Tracing: Go] Update DD_TAGS documentation #27132

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

mtoffl01
Copy link
Contributor

What does this PR do? What is the motivation?

Updates documentation on DD_TAGS. Default value of [] was incorrect because env var values are in string format. By default, no global tags are collected. Also updated the description to specify that key-value pairs must be string-convertible types.
Motivation: Customer request

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@mtoffl01 mtoffl01 requested a review from a team as a code owner January 15, 2025 15:12
@mtoffl01 mtoffl01 changed the title Update go.md [APM Tracing: Go] Update DD_TAGS documentation Jan 15, 2025
@mtoffl01 mtoffl01 requested a review from maycmlee January 15, 2025 15:13
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@michaelcretzman
Copy link
Contributor

@mtoffl01 Approved.
You can merge your PR by adding a comment containing just the command /merge.
The PR will go into the merge queue automatically once it's approved.
FYI - if the PR isn't approved within 2 hours after you add the /merge command you need to add the /merge command again.

@dd-devflow
Copy link

dd-devflow bot commented Jan 16, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-16 21:55:25 UTC ❌ MergeQueue

This PR is rejected because it was updated

@mtoffl01
Copy link
Contributor Author

/merge

@mtoffl01
Copy link
Contributor Author

Hey @michaelcretzman , I'm not sure what happened here? How can we merge this?
Thank you!

@michaelcretzman
Copy link
Contributor

@mtoffl01 do you still need May's review? If not, she or I can merge it

@mtoffl01
Copy link
Contributor Author

No, yours is sufficient! Thank you @michaelcretzman !

@michaelcretzman michaelcretzman merged commit 26cc780 into master Jan 23, 2025
11 checks passed
@michaelcretzman michaelcretzman deleted the mikayla-toffler/patch-DD_Tags branch January 23, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants