Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-9940: Serverless Monitoring for Azure Functions #27294

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Jan 24, 2025

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@cswatt cswatt added the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 24, 2025
@cswatt cswatt requested review from a team as code owners January 24, 2025 19:33
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

Copy link
Contributor

@duncanpharvey duncanpharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started @cswatt! Let me know what you think about my suggestions.

Can we mention that we support runtime metrics and custom metrics and link the relevant documentation?

Could we also have more section (maybe under troubleshooting?) to document that if deploying to a Linux Consumption function with a Github Action that the "Using Azure Service Principal for RBAC as Deployment Credential" method needs to be used?

https://github.com/Azure/functions-action?tab=readme-ov-file#using-azure-service-principal-for-rbac-as-deployment-credential

content/en/serverless/azure_functions/_index.md Outdated Show resolved Hide resolved
content/en/serverless/azure_functions/_index.md Outdated Show resolved Hide resolved
content/en/serverless/azure_functions/_index.md Outdated Show resolved Hide resolved
content/en/serverless/azure_functions/_index.md Outdated Show resolved Hide resolved
content/en/serverless/azure_functions/_index.md Outdated Show resolved Hide resolved
Comment on lines 116 to 118
### Correlate logs and traces

<!-- TODO: to be continued -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop this for now while we work on more logging capabilities

content/en/serverless/azure_functions/_index.md Outdated Show resolved Hide resolved
@cswatt cswatt added editorial review Waiting on a more in-depth review and removed WORK IN PROGRESS No review needed, it's a wip ;) labels Feb 10, 2025
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Feb 10, 2025
patch_all()
```

3. (Optional) **Enable runtime metrics**. See [Node.js Runtime Metrics][2].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. (Optional) **Enable runtime metrics**. See [Node.js Runtime Metrics][2].
3. (Optional) **Enable runtime metrics**. See [Python Runtime Metrics][2].

@@ -0,0 +1,130 @@
---
title: Tracing Azure Functions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe title should be Install Serverless Monitoring for Azure Functions to be in line with https://docs.datadoghq.com/serverless/aws_lambda/installation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants