-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update embedded_apps.md #27532
base: master
Are you sure you want to change the base?
Update embedded_apps.md #27532
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @dgreen15! I left some comments to review.
@@ -93,10 +93,25 @@ To add a button that sets the value of a date range picker component to the dash | |||
- **Value**: `${global?.dashboard?.timeframe}` | |||
1. Save and publish your app. | |||
|
|||
## Add apps to Software Catalog | |||
|
|||
Add a published app to the [Self-Service][2] section of [Software Catalog][3] to provision infrastructure, scaffold services, remediate issues, and more, all from a central place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a published app to the [Self-Service][2] section of [Software Catalog][3] to provision infrastructure, scaffold services, remediate issues, and more, all from a central place. | |
Add a published app to the [Self-Service][2] section of [Software Catalog][3] to provision infrastructure, scaffold services, remediate issues, and more. |
|
||
Add a published app to the [Self-Service][2] section of [Software Catalog][3] to provision infrastructure, scaffold services, remediate issues, and more, all from a central place. | ||
|
||
To add to Self-Service, first ensure your app is published and permissions are defined. Next you can click `Add to Self-Service`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add to Self-Service, first ensure your app is published and permissions are defined. Next you can click `Add to Self-Service`. | |
To add to Self-Service, first ensure your app is published and permissions are defined. Next, you can click **Add to Self-Service**. |
Where does Add to Self-Service appear? Usually we describe which page or section the text is in, so the user knows where to look for it.
|
||
To add to Self-Service, first ensure your app is published and permissions are defined. Next you can click `Add to Self-Service`. | ||
|
||
{{< img src="tracing/service_catalog/self-service-publish.png" alt="Publish to Self-Service" style="width:100%;" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the preview, it looks like the images referenced in the diff are missing. Did you mean to add them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images are added here. Can we merge this after that one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds a section on publishing apps to sw catalog
What does this PR do? What is the motivation?
Merge instructions
Waiting on name changes for Software Catalog to reflect, expecting Feb 18.
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes