-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SINT-2119] Support Go ecosystem #413
Merged
juliendoutre
merged 10 commits into
DataDog:main
from
juliendoutre:julien.doutre/go-support
Jul 17, 2024
Merged
[SINT-2119] Support Go ecosystem #413
juliendoutre
merged 10 commits into
DataDog:main
from
juliendoutre:julien.doutre/go-support
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8db1e5b
to
0a3ec93
Compare
sobregosodd
requested changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left out some comments
sobregosodd
requested changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a couple nits
sobregosodd
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces support for a new ecosystem in guarddog: Golang.
To limit the dependency on external toolchains, I chose not to use the
go
binary to performgo get
orgo list
operations. This came with a couple of caveats I left as TODOs in the code:require
statements and inspect those modules. We should implement the actual MVS algorithm to actually resolve the build list correctly.In order to test this new addition, I simply extended the shady-links semgrep rule to Golang. We can then later think of additional heuristics specific to Go.
Testing
I added tests for the two new scanners added in this PR.
One can test the new feature with: