Simplify local target checks #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikretz
force-pushed
the
ikretz/fix/local-checking
branch
from
ac92c0e
to
3fc3d3f
Compare
sobregosodd
approved these changes
Jul 18, 2024
|
Approved with a couple of nits |
Library Vulnerabilities✅ No library vulnerabilities found (scanned 854d8f5). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three principal changes:
It simplifies the conditions under which Guarddog will decide to perform a local scan: whenever the target is a directory or a regular file in the local filesystem. It also eliminates as much as possible duplicate checks related to local targets
It adds functions in
guarddog/utils/archives.pyfor checking whether a file extension is for a supported archive format and uses them pervasivelyCloses Unused callback function argument in PackageScanner #411