Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add octopus recommended monitor #19419

Draft
wants to merge 64 commits into
base: master
Choose a base branch
from

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Adds a recommended monitor for octopus deploy

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

sarah-witt and others added 23 commits October 17, 2024 14:20
* Add support for server node metrics

* add server node mocks

* remove task id tag

* update caddyfile
* Fix new deployment logic and support in progress and queued deployments

* sync metadata

* update caddyfile

* fix

* add to completed date

* Refactor

* fixed e2e tests

* fixed instance fixture

* fixed e2e test

* added some e2e asserts

* fixed lint error

* all metrics asserted

* Add test asserting metadata, add test and handle failure of tasks

* store base tags

* Don't report completed and executing metrics if no data

* Add support for octopus server node metrics

* remove unused constants

* validate

* lint

* update e2e

* update metadata

* Use project name and project group name tags

* Use space name instead of space id

* Update log lines

* update test instance

* Update metric description

---------

Co-authored-by: Jose Manuel Almaza <[email protected]>
* Add support for deployment logs

* Add server node tag

* add e2e_metrics

* remove completed_time

* Address comments

* add extra assert
* Add support for pagination

* update caddyfile and remove unneeded args

* Apply suggestions
…nment, deployment, and release (#19192)

* Add support for environment metrics

* Add config for autodiscovery

* Add support for environments via discovery

* Add environment, release, and deployment tags

* Add caching for environments, releases, and deployments

* add to caddyfile

* remove env fallback

* change environments cache to dictionary

* use tuple for deployment

* Add pagination for environments

* update caddyfile

* update environments config

* sync models

* Filter by environment

* only collect deploy tasks

* update caddyfile
* Add support for machine metrics

* add role tags

* change to startswith

* validate metadata

* Address comments
* Add support for machine metrics

* add role tags

* change to startswith

* validate metadata

* Address comments

* Add octopus server tag
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 99.16512% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.38%. Comparing base (bef0a2f) to head (b7e6040).
Report is 6 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
aerospike ?
airflow ?
appgate_sdp ?
cassandra ?
cassandra_nodetool ?
ceph ?
cilium ?
clickhouse ?
couchbase ?
dotnetclr ?
duckdb ?
elastic ?
exchange_server ?
gearmand ?
gitlab ?
glusterfs ?
haproxy ?
ibm_ace ?
ibm_was ?
iis ?
jboss_wildfly ?
kafka ?
kafka_consumer ?
keda ?
kubeflow ?
kubevirt_api ?
kubevirt_controller ?
kubevirt_handler ?
marklogic ?
milvus ?
mongo ?
mysql ?
nvidia_nim ?
octopus_deploy 99.16% <99.16%> (?)
openstack_controller ?
pdh_check ?
postgres ?
presto ?
quarkus ?
sap_hana ?
scylla ?
slurm ?
snmp ?
sonarqube ?
sqlserver ?
supabase ?
vault ?
vertica ?
voltdb ?
weblogic ?
windows_performance_counters ?
windows_service ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from sarah/add-octopus-integration to master January 17, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant