Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update State::advance_time to be less indented #1070

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

blt
Copy link
Collaborator

@blt blt commented Oct 28, 2024

What does this PR do?

Following @goxberry's PR review on #1057 this PR attempts to remove the
heavy indentation in State::advance_time. Property tests from #1066 still
pass, so I'd say that was solid feedback. The code flows nicer now.

This was referenced Oct 28, 2024
@blt blt added the no-changelog label Oct 28, 2024 — with Graphite App
@blt blt marked this pull request as ready for review October 28, 2024 23:56
@blt blt requested a review from a team as a code owner October 28, 2024 23:56
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from 5cd5d12 to 7041329 Compare October 29, 2024 00:30
@blt blt force-pushed the blt/update_state_advance_time_to_be_less_indented branch from be91741 to 0731e05 Compare October 29, 2024 00:31
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch 2 times, most recently from 695d044 to 2fe78db Compare October 29, 2024 01:06
@blt blt force-pushed the blt/update_state_advance_time_to_be_less_indented branch from 0731e05 to cb74a84 Compare October 29, 2024 01:06
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from 2fe78db to 0735cf3 Compare October 29, 2024 15:55
@blt blt force-pushed the blt/update_state_advance_time_to_be_less_indented branch 2 times, most recently from 86ef866 to f5bedb0 Compare October 29, 2024 16:01
@blt blt changed the base branch from blt/make_logrotate_fs_a_generator to graphite-base/1070 October 29, 2024 17:00
Following @goxberry's PR review on #1057 this PR attempts to remove the
heavy indentation in State::advance_time. Property tests from #1066 still
pass, so I'd say that was solid feedback. The code flows nicer now.

Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/update_state_advance_time_to_be_less_indented branch from f5bedb0 to 7217520 Compare October 29, 2024 17:00
@blt blt changed the base branch from graphite-base/1070 to main October 29, 2024 17:01
Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/update_state_advance_time_to_be_less_indented branch from 7217520 to e428e0d Compare October 29, 2024 17:01
@blt blt merged commit 0229a82 into main Oct 29, 2024
16 checks passed
Copy link
Collaborator Author

blt commented Oct 29, 2024

Merge activity

  • Oct 29, 1:35 PM EDT: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants