Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AsciiStrings use #680

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Remove AsciiStrings use #680

merged 1 commit into from
Aug 17, 2023

Conversation

blt
Copy link
Collaborator

@blt blt commented Aug 17, 2023

What does this PR do?

This commit removes the use of AsciiStrings struct to generate small strings. Where possible we now use a &str from our Pool mechanism. I have also added a number of new benchmarks for most payloads. This unblocks streaming.

Related issues

REF SMP-664

This commit removes the use of AsciiStrings struct to generate small
strings. Where possible we now use a &str from our `Pool` mechanism. I have also
added a number of new benchmarks for most payloads. This unblocks streaming.

REF SMP-664

Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt requested review from scottopell and a team August 17, 2023 21:07
@github-actions
Copy link

Regression Detector Results

Run ID: 79571fcd-995d-4783-9287-69b87414d9ad
Baseline: 8863b09
Comparison: b92f8eb
Total lading-target CPUs: 4

Explanation

A regression test is an integrated performance test for lading-target in a repeatable rig, with varying configuration for lading-target. What follows is a statistical summary of a brief lading-target run for each configuration across SHAs given above. The goal of these tests are to determine quickly if lading-target performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
blackhole_from_apache_common_http ingress throughput +0.03 [-0.02, +0.08] 61.65%
apache_common_http_both_directions_this_doesnt_make_sense ingress throughput -0.02 [-0.05, +0.02] 49.94%

Copy link
Contributor

@goxberry goxberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool.

@blt blt merged commit 6ca8f96 into main Aug 17, 2023
18 checks passed
@blt blt deleted the more_string_pool branch August 17, 2023 22:40
blt added a commit that referenced this pull request Aug 17, 2023
Follow-up to #680. I realized that the Generator trait could be used with
an associated type to cover owned and reference returns just after #680 merged
up. This commit slightly expands the definition of `Generator` and ensures its
general use.

REF SMP-664

Signed-off-by: Brian L. Troutwine <[email protected]>
blt added a commit that referenced this pull request Aug 18, 2023
Follow-up to #680. I realized that the Generator trait could be used with
an associated type to cover owned and reference returns just after #680 merged
up. This commit slightly expands the definition of `Generator` and ensures its
general use.

REF SMP-664

Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants