-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AsciiStrings use #680
Conversation
This commit removes the use of AsciiStrings struct to generate small strings. Where possible we now use a &str from our `Pool` mechanism. I have also added a number of new benchmarks for most payloads. This unblocks streaming. REF SMP-664 Signed-off-by: Brian L. Troutwine <[email protected]>
Regression Detector ResultsRun ID: 79571fcd-995d-4783-9287-69b87414d9ad ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool.
Follow-up to #680. I realized that the Generator trait could be used with an associated type to cover owned and reference returns just after #680 merged up. This commit slightly expands the definition of `Generator` and ensures its general use. REF SMP-664 Signed-off-by: Brian L. Troutwine <[email protected]>
Follow-up to #680. I realized that the Generator trait could be used with an associated type to cover owned and reference returns just after #680 merged up. This commit slightly expands the definition of `Generator` and ensures its general use. REF SMP-664 Signed-off-by: Brian L. Troutwine <[email protected]>
What does this PR do?
This commit removes the use of AsciiStrings struct to generate small strings. Where possible we now use a &str from our
Pool
mechanism. I have also added a number of new benchmarks for most payloads. This unblocks streaming.Related issues
REF SMP-664