Allow the user to configure the range of DogStatsD metrics #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a configuration option to allow the user to define the range of values that appear in DogStatsD metrics. This range applies to all metric kinds. The distribution is changed from Standard -- "numerically uniform" -- to actually Uniform. We do not allow users to configure the distribution. REF SMP-694 Signed-off-by: Brian L. Troutwine <[email protected]>
GeorgeHahn
approved these changes
Sep 11, 2023
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
numeric_distribution
branch
from
61ecbb6 to
18f2dea
Compare
scottopell
reviewed
Sep 15, 2023
scottopell
reviewed
Sep 15, 2023
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
scottopell
reviewed
Sep 19, 2023
lading_payload/src/dogstatsd.rs
Outdated
| #[derive(Debug, Deserialize, Clone, PartialEq, Copy)] | ||
| pub struct ValueConf { | ||
| /// Odds out of 256 that the value will be a float and not an integer. | ||
| float_weight: u8, |
There was a problem hiding this comment.
This is a fairly unintuitive unit for "chance of thing occurring" (I came here from https://github.com/DataDog/single-machine-performance/pull/1268/files#diff-34dd14dde2466a88f431ddc27fc1d897ffede2f88d81eb37711a0d5886b0af92R29), especially given the prior art of multipack_value_probability.
What do you think of making this a 0-1 value and renaming to probability?
(Also open to renaming/changing multipack_value_probability, just looking for consistency between these two options really)
There was a problem hiding this comment.
Ah, that's a good call-out. I'd rather this be consistent.
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit introduces a configuration option to allow the user to define the range of values that appear in DogStatsD metrics. This range applies to all metric kinds. The distribution is changed from Standard -- "numerically uniform" -- to actually Uniform. We do not allow users to configure the distribution.
Related issues
REF SMP-694