Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects example dogstatsd configuration #717

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

scottopell
Copy link
Contributor

What does this PR do?

Previous example dogstatsd config had a bug where weights of metric_kinds added up to greater than a u8.
Corrects some of the specific values as well.

Motivation

Related issues

Additional Notes

@scottopell scottopell requested a review from a team as a code owner October 20, 2023 20:40
@GeorgeHahn
Copy link
Contributor

Is it invalid for the sum of the weights to be larger than u8::MAX? I spot checked the code and didn't see an issue there.

Copy link
Contributor

@goxberry goxberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; probabilities should be less than or equal to 1.

@scottopell scottopell merged commit 7864e8a into main Nov 30, 2023
14 checks passed
@scottopell scottopell deleted the sopell/dsd-config-default branch November 30, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants