Introduce 'logrotate' log generator #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new log generator that is able to mimic logrotate's operation. This also allows us to mimic how kubernetes logs work by setting `total_rotations` to be zero. REF SMPTNG-44 Signed-off-by: Brian L. Troutwine <[email protected]>
goxberry
reviewed
Nov 2, 2023
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
goxberry
reviewed
Nov 2, 2023
goxberry
reviewed
Nov 2, 2023
goxberry
reviewed
Nov 2, 2023
|
Is this PR still work in progress? It looks as though it isn't yet possible to configure a logrotate file generator via a configuration file. |
|
Otherwise, this is looking good to me. Very cool. |
It is. Seems like the basic idea lands, today I intend to wire it up and try it out on some RCs. |
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
goxberry
approved these changes
Nov 3, 2023
GeorgeHahn
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit introduces a new log generator that is able to mimic logrotate's operation. This also allows us to mimic how kubernetes logs work by setting
total_rotationsto be zero.Related issues
REF SMPTNG-44