Remove streaming cache method #888
Merged
+8
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottopell
approved these changes
May 2, 2024
This commit removes the streaming cache method in favor of the line of work being pursued in #886. We introduced streaming to work around the inability of lading to pack its cache space but the downside of streaming is the race it requires between the generator -- fast -- and the payload creator itself -- slow. This race is always eventually lost by the payload creator and so streaming can never sustain its throughput goals, except at a very low level. Sharp edge, that. Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes the streaming cache method in favor of the line of work being pursued in #886. We introduced streaming to work around the inability of lading to pack its cache space but the downside of streaming is the race it requires between the generator -- fast -- and the payload creator itself -- slow. This race is always eventually lost by the payload creator and so streaming can never sustain its throughput goals, except at a very low level.
Sharp edge, that.