Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless Mini Agent] Update Namespace for Span Tags from Azure Spring Apps and Google Cloud Functions v1 #711

Merged
merged 2 commits into from
Nov 8, 2024
Merged

[Serverless Mini Agent] Update Namespace for Span Tags from Azure Spring Apps and Google Cloud Functions v1 #711

merged 2 commits into from
Nov 8, 2024

Conversation

duncanpharvey
Copy link
Contributor

@duncanpharvey duncanpharvey commented Nov 5, 2024 •
edited
Loading

What does this PR do?

Update namespace for span tags Azure Spring Apps and Google Cloud Functions v1.

Motivation

Make sure span tags from each of these products have a namespace with a consistent naming pattern prior to GA.

https://datadoghq.atlassian.net/browse/SVLS-5915
https://datadoghq.atlassian.net/browse/SVLS-5918

Additional Notes

  • Azure Spring Apps: azurespringapp -> asa
  • Google Cloud Functions v1: gcrfx

How to test the change?

See https://datadoghq.atlassian.net/wiki/spaces/SLS/pages/2977497119/Serverless+Mini+Agent#Testing

@pr-commenter
Copy link

pr-commenter bot commented Nov 5, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-11-08 16:23:59

Comparing candidate commit be032e4 in PR branch duncan-harvey/mini-agent-span-tag-namespaces with baseline commit 573e678 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:tags/replace_trace_tags

  • 🟩 execution_time [-209.009ns; -202.630ns] or [-7.229%; -7.009%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 506.057µs 507.398µs ± 0.673µs 507.369µs ± 0.349µs 507.715µs 508.221µs 508.775µs 513.430µs 1.19% 3.581 30.654 0.13% 0.048µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1947685.399op/s 1970842.917op/s ± 2600.473op/s 1970950.508op/s ± 1357.341op/s 1972347.171op/s 1974159.472op/s 1974808.103op/s 1976061.296op/s 0.26% -3.503 29.770 0.13% 183.881op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 467.733µs 468.442µs ± 0.289µs 468.445µs ± 0.180µs 468.632µs 468.868µs 469.048µs 469.218µs 0.17% -0.197 -0.173 0.06% 0.020µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2131206.972op/s 2134737.701op/s ± 1317.053op/s 2134724.005op/s ± 822.557op/s 2135520.106op/s 2137182.722op/s 2137796.577op/s 2137974.042op/s 0.15% 0.200 -0.172 0.06% 93.130op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.797µs 180.240µs ± 0.197µs 180.234µs ± 0.137µs 180.376µs 180.561µs 180.769µs 180.953µs 0.40% 0.421 0.214 0.11% 0.014µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5526308.802op/s 5548175.314op/s ± 6054.944op/s 5548327.694op/s ± 4205.945op/s 5552465.022op/s 5557363.959op/s 5558439.462op/s 5561828.062op/s 0.24% -0.414 0.200 0.11% 428.149op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.915µs 45.095µs ± 0.069µs 45.093µs ± 0.051µs 45.141µs 45.215µs 45.247µs 45.309µs 0.48% 0.274 -0.023 0.15% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22070732.471op/s 22175581.506op/s ± 33686.616op/s 22176373.576op/s ± 25205.162op/s 22202874.768op/s 22224891.136op/s 22249878.886op/s 22264241.812op/s 0.40% -0.265 -0.031 0.15% 2382.003op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.001µs 49.172µs ± 0.113µs 49.162µs ± 0.044µs 49.210µs 49.290µs 49.357µs 50.435µs 2.59% 7.031 76.327 0.23% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19827381.480op/s 20336840.353op/s ± 45996.486op/s 20340920.687op/s ± 18353.667op/s 20358379.537op/s 20386810.174op/s 20401493.367op/s 20407746.781op/s 0.33% -6.835 73.441 0.23% 3252.443op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.305µs; 507.491µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1970482.516op/s; 1971203.317op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.402µs; 468.482µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2134555.171op/s; 2134920.232op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.212µs; 180.267µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5547336.157op/s; 5549014.471op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.085µs; 45.104µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22170912.865op/s; 22180250.147op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.156µs; 49.188µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20330465.682op/s; 20343215.024op/s] or [-0.031%; +0.031%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 19.319µs 25.962µs ± 11.117µs 20.516µs ± 0.580µs 34.456µs 45.815µs 48.431µs 99.634µs 385.64% 3.244 16.080 42.71% 0.786µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.421µs; 27.502µs] or [-5.935%; +5.935%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 272.109µs 273.920µs ± 0.887µs 273.874µs ± 0.573µs 274.503µs 275.388µs 276.146µs 276.874µs 1.10% 0.398 0.024 0.32% 0.063µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3611749.454op/s 3650734.275op/s ± 11802.694op/s 3651309.220op/s ± 7645.060op/s 3658677.802op/s 3668976.187op/s 3672900.603op/s 3674992.935op/s 0.65% -0.380 -0.005 0.32% 834.576op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 25.766µs 25.913µs ± 0.158µs 25.869µs ± 0.051µs 25.935µs 26.290µs 26.550µs 26.869µs 3.86% 3.071 11.220 0.61% 0.011µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 37218094.876op/s 38592763.563op/s ± 230840.602op/s 38655573.743op/s ± 75472.474op/s 38721224.273op/s 38773390.620op/s 38793972.118op/s 38811006.509op/s 0.40% -3.004 10.696 0.60% 16322.895op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.493µs 15.668µs ± 0.064µs 15.683µs ± 0.015µs 15.696µs 15.756µs 15.825µs 15.839µs 1.00% -0.602 1.037 0.41% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 63134136.364op/s 63824402.632op/s ± 262344.317op/s 63764496.460op/s ± 60411.624op/s 63857249.248op/s 64360271.639op/s 64506422.272op/s 64545556.254op/s 1.22% 0.635 1.036 0.41% 18550.545op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [273.797µs; 274.043µs] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3649098.535op/s; 3652370.015op/s] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [25.891µs; 25.934µs] or [-0.084%; +0.084%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [38560771.275op/s; 38624755.850op/s] or [-0.083%; +0.083%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.659µs; 15.677µs] or [-0.057%; +0.057%] None None None
normalization/normalize_name/normalize_name/good throughput [63788044.233op/s; 63860761.031op/s] or [-0.057%; +0.057%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 140.020µs 140.756µs ± 0.415µs 140.692µs ± 0.152µs 140.877µs 141.510µs 142.664µs 143.069µs 1.69% 2.154 8.428 0.29% 0.029µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [140.698µs; 140.813µs] or [-0.041%; +0.041%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 293.750ns 305.672ns ± 13.772ns 300.009ns ± 4.564ns 310.104ns 337.012ns 341.854ns 344.467ns 14.82% 1.448 0.864 4.49% 0.974ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [303.764ns; 307.581ns] or [-0.624%; +0.624%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.394µs 3.273µs ± 1.405µs 3.128µs ± 0.031µs 3.152µs 3.200µs 14.026µs 15.039µs 380.77% 7.580 57.626 42.82% 0.099µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.078µs; 3.468µs] or [-5.950%; +5.950%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.970µs 38.674µs ± 1.234µs 38.093µs ± 0.061µs 38.227µs 41.346µs 41.390µs 41.432µs 8.77% 1.694 0.897 3.18% 0.087µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.503µs; 38.845µs] or [-0.442%; +0.442%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.629µs 2.685µs ± 0.016µs 2.687µs ± 0.006µs 2.693µs 2.707µs 2.715µs 2.721µs 1.26% -1.349 2.951 0.61% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.683µs; 2.688µs] or [-0.084%; +0.084%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.125µs 1.191µs ± 0.026µs 1.191µs ± 0.018µs 1.212µs 1.216µs 1.218µs 1.218µs 2.25% -1.181 0.647 2.14% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.187µs; 1.194µs] or [-0.298%; +0.298%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.128ms 9.172ms ± 0.014ms 9.172ms ± 0.009ms 9.179ms 9.194ms 9.203ms 9.228ms 0.60% 0.250 0.993 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.170ms; 9.174ms] or [-0.021%; +0.021%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 66.681µs 67.027µs ± 0.155µs 67.025µs ± 0.046µs 67.068µs 67.117µs 67.279µs 68.778µs 2.61% 7.718 82.217 0.23% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.005µs; 67.048µs] or [-0.032%; +0.032%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz be032e4 1731082385 duncan-harvey/mini-agent-span-tag-namespaces
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.610µs 4.621µs ± 0.002µs 4.621µs ± 0.001µs 4.623µs 4.625µs 4.627µs 4.630µs 0.20% 0.132 2.987 0.05% 0.000µs 1 200
credit_card/is_card_number/ throughput 215983626.346op/s 216394570.336op/s ± 108698.740op/s 216413110.140op/s ± 68272.461op/s 216472140.036op/s 216531640.686op/s 216569179.780op/s 216929542.186op/s 0.24% -0.125 3.004 0.05% 7686.162op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.295µs 90.932µs ± 0.300µs 90.915µs ± 0.191µs 91.093µs 91.501µs 91.765µs 91.966µs 1.16% 0.665 0.547 0.33% 0.021µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10873591.240op/s 10997392.850op/s ± 36203.167op/s 10999291.103op/s ± 23053.467op/s 11022911.958op/s 11047521.350op/s 11063316.158op/s 11074817.034op/s 0.69% -0.644 0.507 0.33% 2559.951op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 83.114µs 84.547µs ± 0.625µs 84.462µs ± 0.405µs 84.960µs 85.709µs 85.981µs 86.396µs 2.29% 0.498 -0.003 0.74% 0.044µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11574596.426op/s 11828356.240op/s ± 87095.252op/s 11839698.728op/s ± 56840.124op/s 11891079.609op/s 11945944.402op/s 12003818.976op/s 12031724.523op/s 1.62% -0.460 -0.040 0.73% 6158.564op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.610µs 4.622µs ± 0.003µs 4.621µs ± 0.001µs 4.623µs 4.625µs 4.627µs 4.657µs 0.77% 6.041 65.002 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 214749883.371op/s 216379330.087op/s ± 152475.891op/s 216396710.771op/s ± 62616.951op/s 216452159.561op/s 216518932.770op/s 216561154.204op/s 216940616.015op/s 0.25% -5.977 64.168 0.07% 10781.674op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 79.108µs 80.250µs ± 0.425µs 80.287µs ± 0.303µs 80.574µs 80.896µs 80.923µs 81.200µs 1.14% -0.332 -0.566 0.53% 0.030µs 1 200
credit_card/is_card_number/378282246310005 throughput 12315256.376op/s 12461371.676op/s ± 66039.347op/s 12455253.889op/s ± 47084.675op/s 12504870.391op/s 12574264.249op/s 12612714.184op/s 12641004.080op/s 1.49% 0.353 -0.548 0.53% 4669.687op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.865µs 58.984µs ± 0.134µs 58.919µs ± 0.045µs 59.053µs 59.226µs 59.385µs 59.524µs 1.03% 1.432 1.563 0.23% 0.009µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16800022.611op/s 16953745.551op/s ± 38356.544op/s 16972528.266op/s ± 12966.970op/s 16982351.092op/s 16986299.276op/s 16987424.397op/s 16988096.441op/s 0.09% -1.421 1.515 0.23% 2712.217op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.817µs 6.833µs ± 0.036µs 6.822µs ± 0.002µs 6.824µs 6.903µs 6.985µs 7.079µs 3.77% 3.811 16.492 0.53% 0.003µs 1 200
credit_card/is_card_number/x371413321323331 throughput 141263516.394op/s 146350296.935op/s ± 758360.499op/s 146584403.422op/s ± 46191.105op/s 146631122.457op/s 146657241.789op/s 146672155.954op/s 146693531.796op/s 0.07% -3.750 15.841 0.52% 53624.185op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.609µs 4.621µs ± 0.002µs 4.621µs ± 0.001µs 4.622µs 4.625µs 4.627µs 4.627µs 0.13% -0.379 4.872 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 216121462.659op/s 216392307.771op/s ± 99748.007op/s 216407314.567op/s ± 64004.562op/s 216456381.476op/s 216516629.932op/s 216538380.847op/s 216969588.564op/s 0.26% 0.389 4.919 0.05% 7053.249op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.307µs 73.791µs ± 0.164µs 73.796µs ± 0.101µs 73.902µs 74.037µs 74.196µs 74.288µs 0.67% -0.050 0.384 0.22% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13461097.626op/s 13551845.018op/s ± 30198.269op/s 13550919.248op/s ± 18569.311op/s 13567570.797op/s 13608497.963op/s 13617101.526op/s 13641337.345op/s 0.67% 0.065 0.382 0.22% 2135.340op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 66.201µs 66.628µs ± 0.119µs 66.627µs ± 0.068µs 66.703µs 66.819µs 66.873µs 67.103µs 0.71% -0.086 2.111 0.18% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14902426.609op/s 15008739.516op/s ± 26704.016op/s 15008953.438op/s ± 15404.180op/s 15024029.866op/s 15042729.773op/s 15088812.044op/s 15105422.847op/s 0.64% 0.108 2.115 0.18% 1888.259op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.608µs 4.621µs ± 0.004µs 4.621µs ± 0.001µs 4.622µs 4.624µs 4.625µs 4.673µs 1.13% 9.518 118.186 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 213984441.700op/s 216390602.197op/s ± 194052.042op/s 216405690.400op/s ± 56064.207op/s 216455783.495op/s 216527518.485op/s 216580481.092op/s 216999837.426op/s 0.27% -9.438 116.964 0.09% 13721.551op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 61.981µs 62.296µs ± 0.126µs 62.272µs ± 0.076µs 62.360µs 62.530µs 62.735µs 62.774µs 0.81% 1.106 1.919 0.20% 0.009µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15930231.523op/s 16052396.441op/s ± 32492.846op/s 16058664.198op/s ± 19667.838op/s 16076284.266op/s 16087822.970op/s 16114162.477op/s 16134084.868op/s 0.47% -1.090 1.872 0.20% 2297.591op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.863µs 58.973µs ± 0.150µs 58.909µs ± 0.027µs 58.977µs 59.286µs 59.525µs 59.544µs 1.08% 2.012 3.456 0.25% 0.011µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16794305.031op/s 16956948.719op/s ± 42798.135op/s 16975294.157op/s ± 7707.557op/s 16981836.229op/s 16986066.924op/s 16987540.013op/s 16988653.278op/s 0.08% -2.001 3.398 0.25% 3026.285op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.817µs 6.833µs ± 0.033µs 6.822µs ± 0.002µs 6.824µs 6.904µs 6.961µs 7.012µs 2.78% 3.015 8.910 0.49% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 142613565.780op/s 146342699.851op/s ± 706222.911op/s 146584711.216op/s ± 47863.213op/s 146637201.859op/s 146659490.956op/s 146678028.018op/s 146700049.434op/s 0.08% -2.989 8.699 0.48% 49937.501op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.621µs; 4.622µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ throughput [216379505.736op/s; 216409634.936op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [90.890µs; 90.973µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10992375.440op/s; 11002410.261op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [84.461µs; 84.634µs] or [-0.102%; +0.102%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11816285.676op/s; 11840426.804op/s] or [-0.102%; +0.102%] None None None
credit_card/is_card_number/37828224631 execution_time [4.621µs; 4.622µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [216358198.395op/s; 216400461.779op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [80.191µs; 80.309µs] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/378282246310005 throughput [12452219.258op/s; 12470524.095op/s] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.966µs; 59.003µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16948429.703op/s; 16959061.399op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.828µs; 6.838µs] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/x371413321323331 throughput [146245195.464op/s; 146455398.407op/s] or [-0.072%; +0.072%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.621µs; 4.622µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ throughput [216378483.656op/s; 216406131.885op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.768µs; 73.814µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13547659.828op/s; 13556030.208op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.612µs; 66.644µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15005038.596op/s; 15012440.436op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.621µs; 4.622µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216363708.451op/s; 216417495.944op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.279µs; 62.314µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16047893.245op/s; 16056899.637op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.953µs; 58.994µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16951017.309op/s; 16962880.129op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.829µs; 6.838µs] or [-0.068%; +0.068%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146244824.148op/s; 146440575.555op/s] or [-0.067%; +0.067%] None None None

Baseline

Omitted due to size.

@duncanpharvey duncanpharvey force-pushed the duncan-harvey/mini-agent-span-tag-namespaces branch from 7019bcb to b8a5d07 Compare November 5, 2024 16:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.56%. Comparing base (573e678) to head (be032e4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   71.57%   71.56%   -0.02%     
==========================================
  Files         281      281              
  Lines       42421    42419       -2     
==========================================
- Hits        30363    30356       -7     
- Misses      12058    12063       +5
Components Coverage Δ
crashtracker 43.37% <ø> (ø)
crashtracker-ffi 9.20% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.21% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.75% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 37.42% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.59% <0.00%> (+0.04%) ⬆️

@duncanpharvey duncanpharvey force-pushed the duncan-harvey/mini-agent-span-tag-namespaces branch from 1e23443 to 9ef2ea2 Compare November 8, 2024 15:03
@duncanpharvey duncanpharvey marked this pull request as ready for review November 8, 2024 16:03
@duncanpharvey duncanpharvey requested review from a team as code owners November 8, 2024 16:03
@duncanpharvey duncanpharvey changed the title [Serverless Mini Agent] Update Namespace for Span Tags from Azure Functions, Azure Spring Apps, and Google Cloud Functions v1 [Serverless Mini Agent] Update Namespace for Span Tags from Azure Spring Apps and Google Cloud Functions v1 Nov 8, 2024
@duncanpharvey duncanpharvey enabled auto-merge (squash) November 8, 2024 16:13
@duncanpharvey duncanpharvey merged commit 85c32c8 into main Nov 8, 2024
42 checks passed
@duncanpharvey duncanpharvey deleted the duncan-harvey/mini-agent-span-tag-namespaces branch November 8, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcstorms1 jcstorms1 jcstorms1 approved these changes

Assignees
No one assigned
Labels
mini-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duncanpharvey @codecov-commenter @jcstorms1