Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using lock unnecessarily #784

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Avoid using lock unnecessarily #784

merged 2 commits into from
Dec 6, 2024

Conversation

cataphract
Copy link
Contributor

For to push these changes before merging #515

@cataphract
Avoid using lock unnecessarily
b7a056c 
Avoid moving the mut ref, preferring to reborrow instead. The compiler
doesn't do this transformation automatically because RwLock::new()
doesn't take a mutable ref.

See https://stackoverflow.com/a/62961289/127724
@cataphract cataphract requested a review from a team as a code owner December 6, 2024 11:50
@pr-commenter
Copy link

pr-commenter bot commented Dec 6, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-12-06 15:55:19

Comparing candidate commit f2a7c7d in PR branch glopes/avoid-lock-usage with baseline commit 22a980e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.420µs 3.266µs ± 1.451µs 3.105µs ± 0.021µs 3.125µs 3.183µs 14.365µs 15.342µs 394.10% 7.639 58.193 44.31% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.065µs; 3.467µs] or [-6.156%; +6.156%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 73.281µs 73.495µs ± 0.157µs 73.454µs ± 0.081µs 73.571µs 73.738µs 74.111µs 74.516µs 1.45% 2.453 11.152 0.21% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [73.473µs; 73.516µs] or [-0.030%; +0.030%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 508.626µs 509.671µs ± 0.544µs 509.591µs ± 0.192µs 509.795µs 510.277µs 511.847µs 514.102µs 0.89% 3.997 25.415 0.11% 0.038µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1945140.849op/s 1962051.267op/s ± 2083.773op/s 1962357.142op/s ± 737.839op/s 1963045.212op/s 1964213.327op/s 1964622.972op/s 1966082.759op/s 0.19% -3.960 25.037 0.11% 147.345op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 465.414µs 466.491µs ± 0.444µs 466.437µs ± 0.249µs 466.754µs 467.225µs 467.747µs 468.339µs 0.41% 0.665 1.634 0.09% 0.031µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2135205.242op/s 2143668.005op/s ± 2038.799op/s 2143911.528op/s ± 1145.710op/s 2144949.719op/s 2146597.930op/s 2148267.027op/s 2148625.880op/s 0.22% -0.656 1.612 0.09% 144.165op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.360µs 176.473µs ± 0.511µs 176.527µs ± 0.379µs 176.832µs 177.300µs 177.584µs 177.699µs 0.66% -0.018 -0.610 0.29% 0.036µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5627483.642op/s 5666644.581op/s ± 16422.786op/s 5664850.324op/s ± 12149.769op/s 5680572.216op/s 5693864.659op/s 5699503.136op/s 5702550.779op/s 0.67% 0.030 -0.615 0.29% 1161.266op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.121µs 45.438µs ± 0.114µs 45.444µs ± 0.079µs 45.515µs 45.623µs 45.682µs 45.688µs 0.54% -0.140 -0.385 0.25% 0.008µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21887435.867op/s 22008045.799op/s ± 55276.806op/s 22004864.792op/s ± 38294.058op/s 22047217.073op/s 22100225.849op/s 22130519.873op/s 22162462.165op/s 0.72% 0.152 -0.380 0.25% 3908.660op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 41.832µs 42.168µs ± 0.242µs 42.109µs ± 0.200µs 42.398µs 42.524µs 42.622µs 42.796µs 1.63% 0.272 -1.373 0.57% 0.017µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 23366525.783op/s 23715341.277op/s ± 136108.174op/s 23748103.695op/s ± 113310.268op/s 23844846.572op/s 23885051.066op/s 23902019.874op/s 23904968.556op/s 0.66% -0.263 -1.386 0.57% 9624.301op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [509.596µs; 509.747µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1961762.476op/s; 1962340.058op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [466.429µs; 466.552µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2143385.447op/s; 2143950.563op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.402µs; 176.544µs] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5664368.541op/s; 5668920.622op/s] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.422µs; 45.454µs] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22000384.966op/s; 22015706.633op/s] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [42.135µs; 42.202µs] or [-0.080%; +0.080%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [23696477.993op/s; 23734204.561op/s] or [-0.080%; +0.080%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.579µs 2.644µs ± 0.018µs 2.646µs ± 0.004µs 2.650µs 2.666µs 2.679µs 2.682µs 1.36% -1.975 5.084 0.66% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.641µs; 2.646µs] or [-0.092%; +0.092%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.611µs 4.628µs ± 0.006µs 4.628µs ± 0.004µs 4.631µs 4.636µs 4.639µs 4.673µs 0.97% 1.684 12.034 0.13% 0.000µs 1 200
credit_card/is_card_number/ throughput 214014332.223op/s 216090733.296op/s ± 291361.614op/s 216095265.602op/s ± 179124.070op/s 216275843.631op/s 216516428.517op/s 216701169.007op/s 216872586.853op/s 0.36% -1.639 11.672 0.13% 20602.377op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 96.289µs 96.473µs ± 0.340µs 96.443µs ± 0.031µs 96.476µs 96.552µs 96.669µs 101.176µs 4.91% 13.342 181.997 0.35% 0.024µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 9883802.595op/s 10365716.234op/s ± 34891.948op/s 10368810.101op/s ± 3287.925op/s 10371849.504op/s 10376930.734op/s 10382985.385op/s 10385381.537op/s 0.16% -13.278 180.795 0.34% 2467.233op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 88.354µs 88.685µs ± 0.378µs 88.645µs ± 0.123µs 88.772µs 89.023µs 89.316µs 93.264µs 5.21% 8.983 105.525 0.43% 0.027µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10722218.258op/s 11276103.198op/s ± 46378.314op/s 11281001.102op/s ± 15652.264op/s 11296319.095op/s 11313154.823op/s 11315385.564op/s 11318119.177op/s 0.33% -8.643 99.992 0.41% 3279.442op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.610µs 4.627µs ± 0.007µs 4.627µs ± 0.003µs 4.630µs 4.635µs 4.638µs 4.699µs 1.55% 5.333 54.649 0.15% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 212809621.990op/s 216106521.948op/s ± 322488.716op/s 216110908.124op/s ± 132867.248op/s 216258926.813op/s 216471868.807op/s 216698641.906op/s 216934771.932op/s 0.38% -5.208 53.034 0.15% 22803.396op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 84.851µs 85.523µs ± 0.282µs 85.504µs ± 0.173µs 85.699µs 86.022µs 86.216µs 86.531µs 1.20% 0.375 0.527 0.33% 0.020µs 1 200
credit_card/is_card_number/378282246310005 throughput 11556505.583op/s 11692885.242op/s ± 38576.845op/s 11695340.735op/s ± 23638.951op/s 11717524.738op/s 11753196.010op/s 11774765.524op/s 11785368.465op/s 0.77% -0.351 0.493 0.33% 2727.795op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 64.182µs 64.311µs ± 0.089µs 64.303µs ± 0.024µs 64.328µs 64.382µs 64.405µs 65.453µs 1.79% 10.534 132.470 0.14% 0.006µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 15278119.060op/s 15549440.311op/s ± 21270.646op/s 15551365.438op/s ± 5687.250op/s 15556706.852op/s 15563092.127op/s 15572442.912op/s 15580602.150op/s 0.19% -10.436 130.816 0.14% 1504.062op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.833µs 6.845µs ± 0.004µs 6.844µs ± 0.003µs 6.847µs 6.853µs 6.856µs 6.856µs 0.17% 0.258 0.142 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145854267.045op/s 146099443.597op/s ± 93493.235op/s 146107754.871op/s ± 57552.794op/s 146159758.580op/s 146232455.747op/s 146307826.266op/s 146339271.084op/s 0.16% -0.254 0.141 0.06% 6610.970op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.612µs 4.627µs ± 0.006µs 4.626µs ± 0.004µs 4.631µs 4.637µs 4.642µs 4.645µs 0.40% 0.200 -0.085 0.13% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215286452.908op/s 216128045.874op/s ± 285552.694op/s 216152519.196op/s ± 193486.114op/s 216319295.681op/s 216572498.218op/s 216747481.027op/s 216841279.201op/s 0.32% -0.193 -0.090 0.13% 20191.625op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 76.929µs 77.332µs ± 0.130µs 77.334µs ± 0.093µs 77.427µs 77.524µs 77.606µs 77.641µs 0.40% -0.200 -0.258 0.17% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 12879874.562op/s 12931274.386op/s ± 21774.622op/s 12930999.540op/s ± 15626.953op/s 12946437.034op/s 12968657.866op/s 12980332.996op/s 12999073.166op/s 0.53% 0.208 -0.251 0.17% 1539.698op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 68.842µs 69.189µs ± 0.137µs 69.194µs ± 0.093µs 69.291µs 69.393µs 69.510µs 69.527µs 0.48% -0.141 -0.190 0.20% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14382920.153op/s 14453208.970op/s ± 28548.040op/s 14452031.540op/s ± 19329.741op/s 14470204.415op/s 14504341.524op/s 14521395.443op/s 14526029.192op/s 0.51% 0.151 -0.188 0.20% 2018.651op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.614µs 4.629µs ± 0.005µs 4.629µs ± 0.003µs 4.632µs 4.637µs 4.641µs 4.644µs 0.33% 0.012 0.001 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215340579.911op/s 216040941.437op/s ± 248332.200op/s 216042424.698op/s ± 163150.453op/s 216195179.949op/s 216472817.089op/s 216570484.453op/s 216722013.852op/s 0.31% -0.005 -0.000 0.11% 17559.738op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 65.157µs 65.489µs ± 0.131µs 65.497µs ± 0.083µs 65.576µs 65.690µs 65.746µs 65.761µs 0.40% -0.197 -0.436 0.20% 0.009µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15206605.590op/s 15269865.130op/s ± 30460.749op/s 15267858.105op/s ± 19318.115op/s 15287870.985op/s 15321314.590op/s 15339897.648op/s 15347656.007op/s 0.52% 0.206 -0.431 0.20% 2153.900op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 64.200µs 64.300µs ± 0.031µs 64.301µs ± 0.020µs 64.319µs 64.350µs 64.366µs 64.383µs 0.13% -0.128 0.404 0.05% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 15531945.229op/s 15552172.127op/s ± 7564.606op/s 15551924.336op/s ± 4727.944op/s 15556857.334op/s 15563110.992op/s 15571227.658op/s 15576386.199op/s 0.16% 0.131 0.407 0.05% 534.898op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.833µs 6.843µs ± 0.004µs 6.843µs ± 0.002µs 6.846µs 6.849µs 6.850µs 6.853µs 0.15% -0.519 0.501 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145915023.525op/s 146132302.743op/s ± 81699.900op/s 146128041.972op/s ± 45052.596op/s 146170976.973op/s 146305917.532op/s 146344198.859op/s 146351490.401op/s 0.15% 0.523 0.503 0.06% 5777.055op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.627µs; 4.629µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/ throughput [216050353.379op/s; 216131113.214op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [96.426µs; 96.520µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10360880.545op/s; 10370551.922op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [88.632µs; 88.737µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11269675.609op/s; 11282530.786op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/37828224631 execution_time [4.626µs; 4.628µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/37828224631 throughput [216061828.113op/s; 216151215.782op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/378282246310005 execution_time [85.484µs; 85.562µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/378282246310005 throughput [11687538.862op/s; 11698231.622op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [64.299µs; 64.323µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [15546492.404op/s; 15552388.218op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.844µs; 6.845µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 throughput [146086486.333op/s; 146112400.860op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.626µs; 4.628µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/ throughput [216088471.017op/s; 216167620.731op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [77.314µs; 77.350µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [12928256.633op/s; 12934292.139op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [69.170µs; 69.208µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [14449252.486op/s; 14457165.454op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.628µs; 4.629µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216006524.982op/s; 216075357.892op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [65.471µs; 65.507µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15265643.563op/s; 15274086.697op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [64.295µs; 64.304µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [15551123.745op/s; 15553220.509op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.843µs; 6.844µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146120979.923op/s; 146143625.563op/s] or [-0.008%; +0.008%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.522ms 6.541ms ± 0.011ms 6.540ms ± 0.004ms 6.544ms 6.551ms 6.556ms 6.661ms 1.85% 6.933 73.166 0.17% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.539ms; 6.542ms] or [-0.023%; +0.023%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 280.223µs 280.820µs ± 0.297µs 280.766µs ± 0.148µs 280.931µs 281.348µs 281.717µs 282.429µs 0.59% 1.785 5.968 0.11% 0.021µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3540708.996op/s 3561000.951op/s ± 3757.266op/s 3561678.695op/s ± 1874.613op/s 3563298.918op/s 3565691.475op/s 3566326.576op/s 3568585.130op/s 0.19% -1.770 5.881 0.11% 265.679op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.160µs 27.313µs ± 0.052µs 27.308µs ± 0.031µs 27.347µs 27.387µs 27.442µs 27.529µs 0.81% 0.163 1.745 0.19% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 36325166.283op/s 36613351.381op/s ± 69309.583op/s 36618909.804op/s ± 41626.644op/s 36649128.433op/s 36727823.744op/s 36796784.422op/s 36818928.716op/s 0.55% -0.142 1.716 0.19% 4900.928op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.573µs 16.671µs ± 0.042µs 16.670µs ± 0.028µs 16.698µs 16.735µs 16.769µs 16.808µs 0.83% 0.231 0.007 0.25% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 59495357.328op/s 59985678.538op/s ± 150673.630op/s 59986449.218op/s ± 100923.986op/s 60087411.777op/s 60227297.825op/s 60298573.917op/s 60339074.656op/s 0.59% -0.216 -0.009 0.25% 10654.235op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [280.779µs; 280.861µs] or [-0.015%; +0.015%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3560480.230op/s; 3561521.672op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.305µs; 27.320µs] or [-0.026%; +0.026%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36603745.740op/s; 36622957.023op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.665µs; 16.677µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/good throughput [59964796.622op/s; 60006560.454op/s] or [-0.035%; +0.035%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 296.675ns 310.726ns ± 13.586ns 305.054ns ± 5.758ns 325.185ns 336.246ns 346.380ns 349.076ns 14.43% 1.047 -0.077 4.36% 0.961ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [308.843ns; 312.609ns] or [-0.606%; +0.606%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 35.835µs 36.353µs ± 0.829µs 35.975µs ± 0.052µs 36.047µs 38.070µs 38.142µs 39.975µs 11.12% 1.814 1.941 2.27% 0.059µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [36.238µs; 36.467µs] or [-0.316%; +0.316%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 142.718µs 143.430µs ± 0.382µs 143.381µs ± 0.176µs 143.541µs 144.197µs 144.772µs 145.475µs 1.46% 1.698 5.066 0.27% 0.027µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [143.377µs; 143.483µs] or [-0.037%; +0.037%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.263ms 59.038ms ± 0.188ms 59.053ms ± 0.117ms 59.129ms 59.295ms 59.627ms 59.865ms 1.37% 0.591 4.052 0.32% 0.013ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [59.012ms; 59.064ms] or [-0.044%; +0.044%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2a7c7d 1733499871 glopes/avoid-lock-usage
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.302µs 24.465µs ± 13.883µs 18.614µs ± 0.109µs 19.764µs 45.313µs 48.632µs 150.346µs 707.69% 4.993 36.942 56.61% 0.982µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.541µs; 26.389µs] or [-7.865%; +7.865%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.20%. Comparing base (22a980e) to head (f2a7c7d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   71.21%   71.20%   -0.01%     
==========================================
  Files         301      301              
  Lines       44705    44704       -1     
==========================================
- Hits        31836    31831       -5     
- Misses      12869    12873       +4
Components Coverage Δ
crashtracker 44.89% <ø> (ø)
crashtracker-ffi 8.41% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.94% <ø> (ø)
data-pipeline-ffi 86.29% <ø> (ø)
ddcommon 83.28% <ø> (ø)
ddcommon-ffi 68.68% <ø> (ø)
ddtelemetry 59.45% <100.00%> (-0.02%) ⬇️
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.82% <ø> (+0.06%) ⬆️
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 37.96% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.38% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.43% <ø> (ø)

@cataphract cataphract enabled auto-merge (rebase) December 6, 2024 15:44
@cataphract cataphract merged commit 27f5f5f into main Dec 6, 2024
33 checks passed
@cataphract cataphract deleted the glopes/avoid-lock-usage branch December 6, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bantonsson bantonsson bantonsson approved these changes

@paullegranddc paullegranddc Awaiting requested review from paullegranddc paullegranddc is a code owner automatically assigned from DataDog/libdatadog-telemetry

Assignees
No one assigned
Labels
telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cataphract @codecov-commenter @bantonsson