Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
mabdinur authored Nov 25, 2024
1 parent 9ab11b5 commit 7d12aca
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion utils/parametric/_library_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,8 @@ def __exit__(self, exc_type, exc_val, exc_tb):
# Only attempt a flush if there was no exception raised.
if exc_type is None:
self.dd_flush()
if self.lang != "cpp":
if self.lang not in ("cpp", "nodejs"):
# FIXME(munir): nodejs app does not support calling otel_flush if otel spans are not created
# C++ does not have an otel_flush endpoint
self.otel_flush(1)

Expand Down

0 comments on commit 7d12aca

Please sign in to comment.