-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
skip nodejs test and fix namespace assertion
- Loading branch information
Showing
1 changed file
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -309,7 +309,7 @@ def test_telemetry_otel_env_hiding(self, library_env, test_agent, test_library): | |
|
||
metrics = payload["series"] | ||
# python tracer stores all telemetry metrics under the tracer namespace, it seems like nodejs and golang do not | ||
assert payload["namespace"] == "tracer" or payload["namespace"] == "tracers" | ||
assert payload["namespace"] == "tracers" | ||
otelHiding = [s for s in metrics if s["metric"] == "otel.env.hiding"] | ||
assert not [s for s in metrics if s["metric"] == "otel.env.invalid"] | ||
|
||
|
@@ -353,7 +353,7 @@ def test_telemetry_otel_env_hiding(self, library_env, test_agent, test_library): | |
@missing_feature(context.library == "ruby", reason="Not implemented") | ||
@missing_feature(context.library == "php", reason="Not implemented") | ||
@missing_feature(context.library == "cpp", reason="Not implemented") | ||
@missing_feature(context.library < "[email protected]", reason="Not implemented") | ||
@missing_feature(context.library == "does not collect env.invalid metrics for otel_resource_attributes", reason="nodejs") | ||
@pytest.mark.parametrize( | ||
"library_env", | ||
[ | ||
|
@@ -385,7 +385,7 @@ def test_telemetry_otel_env_invalid(self, library_env, test_agent, test_library) | |
|
||
metrics = payload["series"] | ||
|
||
assert payload["namespace"] == "tracers" or payload["namespace"] == "tracer" | ||
assert payload["namespace"] == "tracers" | ||
|
||
otel_invalid = [s for s in metrics if s["metric"] == "otel.env.invalid"] | ||
|
||
|
@@ -406,7 +406,7 @@ def test_telemetry_otel_env_invalid(self, library_env, test_agent, test_library) | |
["dd_trace_sample_rate", "otel_traces_sampler"], | ||
["dd_trace_enabled", "otel_traces_exporter"], | ||
["dd_runtime_metrics_enabled", "otel_metrics_exporter"], | ||
# ["dd_tags", "otel_resource_attributes"], not supported by nodejs | ||
["dd_tags", "otel_resource_attributes"], | ||
["dd_trace_otel_enabled", "otel_sdk_disabled"], | ||
[ddlog_config, "otel_log_level"], | ||
["dd_trace_sample_rate", otelsampler_config], | ||
|