Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a panic related to noop embeded span context in ddtrace/opentelemetry #1779

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

dianashevchenko
Copy link
Contributor

Description

Related to DataDog/dd-trace-go#2284
Embedding a noop.Span caused a panic when casting a span to ddtrace.Span

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@katiehockman katiehockman force-pushed the shevchenko/fix-noop-embed-span branch from a557a13 to c4acb32 Compare November 10, 2023 18:08
@katiehockman
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 10, 2023

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

you can cancel this operation by commenting your pull request with /merge -c!

@katiehockman
Copy link
Contributor

/remove

@dd-devflow
Copy link

dd-devflow bot commented Nov 10, 2023

🚂 Devflow: remove

@dd-devflow
Copy link

dd-devflow bot commented Nov 10, 2023

⚠️ MergeQueue

This merge request was unqueued

If you need support, contact us on slack #ci-interfaces!

@katiehockman katiehockman merged commit 6998b30 into main Nov 10, 2023
193 of 225 checks passed
@katiehockman katiehockman deleted the shevchenko/fix-noop-embed-span branch November 10, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants