-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a panic related to noop embeded span context in ddtrace/opentelemetry #1779
Conversation
a557a13
to
c4acb32
Compare
/merge |
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. you can cancel this operation by commenting your pull request with |
/remove |
🚂 Devflow: |
This merge request was unqueued If you need support, contact us on slack #ci-interfaces! |
Description
Related to DataDog/dd-trace-go#2284
Embedding a
noop.Span
caused a panic when casting a span toddtrace.Span
Motivation
Workflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario
,run-profiling-scenario
...). If this PR modifies any system-tests internal, then add therun-all-scenarios
label (more info).build-some-image
label is present