Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add older debian tests [APMON-1505] #3172

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

emmettbutler
Copy link
Contributor

@emmettbutler emmettbutler commented Oct 3, 2024

This change adds debian 11 and 10 to the list of auto-injection tested OSes

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@emmettbutler emmettbutler requested a review from a team as a code owner October 3, 2024 16:10
@emmettbutler emmettbutler changed the title add older debian tests add older debian tests [APMON-1505] Oct 8, 2024
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried in GitLab and it's failing because a timeout.
It's trying to generate the AMI, and executing the test for all other "not default" vms.
To test this, I advocate adding the "--vm-only-branch debian" in the gitlab ci (job onboarding_install_extra_vms). Run the tests with this change, and then remove the change before merge

@emmettbutler
Copy link
Contributor Author

@robertomonteromiguel this actually passes on my local

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is in conflict with main branch.
For example you are adding java provisions that have been removed two weeks ago.
I encourage you to do the complete execution of the pipeline.
I use to trick the gitlab.yml by adding the parameter “--vm-only-branch debian”. After I do the full pipeline run and see that the new machines don't fail, I remove these changes before merge

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are failures on the CI. Java:

     default-jdk : Depends: default-jre (= 2:1.21-76) but it is not going to be installed
                   Depends: openjdk-21-jdk but it is not going to be installed
     libc6 : Breaks: chrony (< 4.2-3~) but 3.4-4+deb10u2 is to be installed
    E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.```

utils/_context/virtual_machines.py Outdated Show resolved Hide resolved
utils/_context/virtual_machines.py Outdated Show resolved Hide resolved
@@ -14,7 +14,7 @@
sudo apt-get update
sudo apt-get -y install docker-ce docker-ce-cli containerd.io docker-compose-plugin
sudo apt-get -y install docker-buildx-plugin || true #Ubuntu 21.04 doesn't have this package
sudo curl -L https://github.com/docker/compose/releases/latest/download/docker-compose-$(uname -s)-$(uname -m) -o /usr/bin/docker-compose && sudo chmod +x /usr/bin/docker-compose && sudo docker-compose --version
sudo curl -L https://github.com/docker/compose/releases/latest/download/docker-compose-linux-$(uname -m) -o /usr/bin/docker-compose && sudo chmod +x /usr/bin/docker-compose && sudo docker-compose --version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check if this change impacts on other machines

@@ -8,11 +8,11 @@ lang_variant:
remote-command: |
echo 'deb http://deb.debian.org/debian unstable main non-free contrib' | sudo tee -a /etc/apt/sources.list
sudo apt update
sudo apt -y install openjdk-8-jdk-headless
sudo apt -y install openjdk-8-jdk-headless openjdk-8-jre-headless
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are installing the jdk, we shoudn't need the jre

@emmettbutler
Copy link
Contributor Author

@natitsechanski @robertomonteromiguel I'm having a really tough time debugging the Java errors here. Beyond that, since there are some expected-failing tests, it's not clear to me how to track down meaningful error messages here.

@robertomonteromiguel
Copy link
Collaborator

robertomonteromiguel commented Nov 18, 2024

@natitsechanski @robertomonteromiguel I'm having a really tough time debugging the Java errors here. Beyond that, since there are some expected-failing tests, it's not clear to me how to track down meaningful error messages here.

Checking the logs, there are failures on the java installation process. Like this:

     installed ca-certificates-java package post-installation script subprocess returned error exit status 1
    Setting up default-jre-headless (2:1.11-71) ...
    dpkg: dependency problems prevent configuration of openjdk-11-jre-headless:arm64:
     openjdk-11-jre-headless:arm64 depends on ca-certificates-java (>= 20190405~); however:
      Package ca-certificates-java is not configured yet.

I recommend that you run the machine locally and try the installation commands manually.

@emmettbutler
Copy link
Contributor Author

@robertomonteromiguel are there instructions anywhere about how to run the machine locally?

@robertomonteromiguel
Copy link
Collaborator

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several failures in the pipeline. Check here: https://gitlab.ddbuild.io/DataDog/system-tests/-/pipelines/50273096

For example, debian 10 is installing python 2.7. You should exclude in the normal scenario and add to the unsupported scenario.
Nodejs is failing due to debian 10 can find the package nodejs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants