-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add older debian tests [APMON-1505] #3172
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried in GitLab and it's failing because a timeout.
It's trying to generate the AMI, and executing the test for all other "not default" vms.
To test this, I advocate adding the "--vm-only-branch debian"
in the gitlab ci (job onboarding_install_extra_vms). Run the tests with this change, and then remove the change before merge
@robertomonteromiguel this actually passes on my local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is in conflict with main branch.
For example you are adding java provisions that have been removed two weeks ago.
I encourage you to do the complete execution of the pipeline.
I use to trick the gitlab.yml by adding the parameter “--vm-only-branch debian”. After I do the full pipeline run and see that the new machines don't fail, I remove these changes before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are failures on the CI. Java:
default-jdk : Depends: default-jre (= 2:1.21-76) but it is not going to be installed
Depends: openjdk-21-jdk but it is not going to be installed
libc6 : Breaks: chrony (< 4.2-3~) but 3.4-4+deb10u2 is to be installed
E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.```
@@ -14,7 +14,7 @@ | |||
sudo apt-get update | |||
sudo apt-get -y install docker-ce docker-ce-cli containerd.io docker-compose-plugin | |||
sudo apt-get -y install docker-buildx-plugin || true #Ubuntu 21.04 doesn't have this package | |||
sudo curl -L https://github.com/docker/compose/releases/latest/download/docker-compose-$(uname -s)-$(uname -m) -o /usr/bin/docker-compose && sudo chmod +x /usr/bin/docker-compose && sudo docker-compose --version | |||
sudo curl -L https://github.com/docker/compose/releases/latest/download/docker-compose-linux-$(uname -m) -o /usr/bin/docker-compose && sudo chmod +x /usr/bin/docker-compose && sudo docker-compose --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to check if this change impacts on other machines
@@ -8,11 +8,11 @@ lang_variant: | |||
remote-command: | | |||
echo 'deb http://deb.debian.org/debian unstable main non-free contrib' | sudo tee -a /etc/apt/sources.list | |||
sudo apt update | |||
sudo apt -y install openjdk-8-jdk-headless | |||
sudo apt -y install openjdk-8-jdk-headless openjdk-8-jre-headless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are installing the jdk, we shoudn't need the jre
@natitsechanski @robertomonteromiguel I'm having a really tough time debugging the Java errors here. Beyond that, since there are some expected-failing tests, it's not clear to me how to track down meaningful error messages here. |
Checking the logs, there are failures on the java installation process. Like this:
I recommend that you run the machine locally and try the installation commands manually. |
@robertomonteromiguel are there instructions anywhere about how to run the machine locally? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several failures in the pipeline. Check here: https://gitlab.ddbuild.io/DataDog/system-tests/-/pipelines/50273096
For example, debian 10 is installing python 2.7. You should exclude in the normal scenario and add to the unsupported scenario.
Nodejs is failing due to debian 10 can find the package nodejs
This change adds debian 11 and 10 to the list of auto-injection tested OSes
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present