Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametric: adds dd_ prefix to APMLibrary methods that interact with the Datadog API #3511

Merged
merged 11 commits into from
Nov 22, 2024

Conversation

mabdinur
Copy link
Contributor

Motivation

  • OpenTelemetry parametric library interfaces are prefixed with otel_ but Datadog interfaces do not have a prefix. This PR adds a dd_ prefix to APMLibrary operation that interact with Datadog APIs.

Changes

  • Renames:

    • APMLibrary.start_span to APMLibrary.dd_start_span
    • APMLibrary.flush to APMLibrary.dd_flush
    • APMLibrary.inject_headers to APMLibrary.dd_inject_headers
    • APMLibrary.extract_headers to APMLibrary.dd_extract_headers
    • APMLibrary.current_span to APMLibrary.dd_current_span
    • APMLibrary.get_tracer_config to APMLibrary.config, this interface can retrieve configurations that are not unique to tracing.
  • Removes:

    • APMLibrary.finish_span this method is not used

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur changed the title parametric: make datadog library operations explicit parametric: add dd_ perfix to datadog library operations Nov 20, 2024
@mabdinur mabdinur changed the title parametric: add dd_ perfix to datadog library operations parametric: adds dd_ perfix to datadog library operations Nov 20, 2024
@mabdinur mabdinur changed the title parametric: adds dd_ perfix to datadog library operations parametric: adds dd_ prefix to APMLibrary methods that interact with the Datadog API Nov 20, 2024
@mabdinur mabdinur force-pushed the munir/make-dd-interface-explicit branch from 38897d3 to 3d2b470 Compare November 21, 2024 03:33
@mabdinur mabdinur marked this pull request as ready for review November 21, 2024 21:25
@mabdinur mabdinur requested review from a team as code owners November 21, 2024 21:25
@mabdinur mabdinur requested review from ZStriker19 and removed request for a team November 21, 2024 21:25
@mabdinur mabdinur merged commit 8dc2e49 into main Nov 22, 2024
398 of 399 checks passed
@mabdinur mabdinur deleted the munir/make-dd-interface-explicit branch November 22, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants