Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] fix iast standalone manifest, and django poc #3539

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Nov 25, 2024

Motivation

The manifest lines for iast standalone were incorrect. Also fix django poc by adding the missing routes

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@gnufede gnufede changed the title [python] fix manifest [python] fix iast standalone manifest Nov 25, 2024
@gnufede gnufede marked this pull request as ready for review November 25, 2024 11:24
@gnufede gnufede requested review from a team as code owners November 25, 2024 11:24
@gnufede gnufede requested review from taegyunkim and mabdinur and removed request for a team November 25, 2024 11:24
@gnufede gnufede requested a review from a team as a code owner November 25, 2024 12:46
@gnufede gnufede changed the title [python] fix iast standalone manifest [python] fix iast standalone manifest, and django poc Nov 25, 2024
@gnufede gnufede merged commit bdff63f into main Nov 25, 2024
78 checks passed
@gnufede gnufede deleted the gnufede/python-fix-manifest branch November 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants