Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametric: avoid redefining otel SpanKind and StatusCode #3543

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 25, 2024

Motivation

  • Use the definitions of SpanKind and Status Code provided by the opentelemetry-api (link).

Changes

  • Removes SpanKind and StatusCode enums from dd_constants
  • Replaces all references to dd_constants.SpanKind and dd_constants.StatusCode with opentelemetry.trace.SpanKind and opentelemetry.trace.StatusCode.
  • Updates all parametric apps to support the enum values returned by the python SpanKind enum (the main change here is that otel SpanKind values start at 0 instead of 1).

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur marked this pull request as ready for review November 25, 2024 18:05
@mabdinur mabdinur requested review from a team as code owners November 25, 2024 18:05
@mabdinur mabdinur requested review from khanayan123, sanchda, wantsui, manuel-alvarez-alvarez and jandro996 and removed request for a team November 25, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant