Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametric: flush finished otel spans when APMLibrary contextmanager exits #3545

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

mabdinur
Copy link
Contributor

Motivation

  • Improve the reliability of opentelemetry tests. This change should reduce the wait time for retrieving spans from the testagent.

Changes

  • Calls APMLibrary.otel_flush in APMLibrary.__exit__() for all libraries except cpp (which does not support the otel api).

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur marked this pull request as ready for review November 25, 2024 18:04
@mabdinur mabdinur requested review from a team as code owners November 25, 2024 18:04
@mabdinur mabdinur merged commit 3d18f99 into main Nov 25, 2024
297 checks passed
@mabdinur mabdinur deleted the munir/otel-flush branch November 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants