Add test to check absence of client computed stats #3812
Merged
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estringana
force-pushed
the
estringana/test-asm-standalone-not-enabled
branch
8 times, most recently
from
ebd5622 to
ef1e175
Compare
jandro996
reviewed
Jan 16, 2025
There was a problem hiding this comment.
I'm not sure if there is a current test in another scenario that checks this datadog-client-computed-stats header, but IMHO we need one more test case that checks datadog-client-computed-stats=true when standalone billing is disabled and metrics enabled, to ensure the previous is working as before the asm feature was implemented.
There was a problem hiding this comment.
Not sure if I'm following you correctly. How would you make APM to send the header datadog-client-computed-stats=true? In PHP that header was not sent
There was a problem hiding this comment.
Maybe it's something that only happens in java, but the header is set with empty value, but to keep it simple we can continue with the PR as it is
estringana
force-pushed
the
estringana/test-asm-standalone-not-enabled
branch
from
06e9ddb to
39a1b00
Compare
cbeauchesne
requested changes
Jan 20, 2025
estringana
force-pushed
the
estringana/test-asm-standalone-not-enabled
branch
from
4dacb21 to
9d85bd9
Compare
cbeauchesne
requested changes
Jan 23, 2025
estringana
force-pushed
the
estringana/test-asm-standalone-not-enabled
branch
2 times, most recently
from
3500a27 to
e954ad2
Compare
cbeauchesne
requested changes
Jan 27, 2025
iunanua
reviewed
Jan 28, 2025
estringana
force-pushed
the
estringana/test-asm-standalone-not-enabled
branch
from
a76ca84 to
edb3d81
Compare
cbeauchesne
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The added test is a regression test which caused a incident on PHP. When ASM Standalone was implemented, it was required to send the header
Datadog-Client-Computed-Statsasyeswhen it was a ASM Standalone request. However the way it was implemented in PHP was to add the headerDatadog-Client-Computed-Statsalways. Then the value of the header wasyeswhen it was a ASM Standalone request andnowhen not. This was generating the agent to never compute stats as it was interpreting the valuenoas if it wasyes.Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present