Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] deduplication enabled env var #3881

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

avara1986
Copy link
Member

Motivation

Python implements now DD_IAST_DEDUPLICATION_ENABLED instead of _DD_APPSEC_DEDUPLICATION_ENABLED. with that, we don't need the old env variable anymore.
DataDog/dd-trace-py#12022

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@avara1986 avara1986 force-pushed the avara1986/APPSEC-56474-iast_deduplication_env_var branch from 3558be3 to cef509b Compare January 23, 2025 08:56
@avara1986 avara1986 changed the title chore(iast): deduplication enabled env var [python] deduplication enabled env var Jan 23, 2025
Copy link
Member

@gnufede gnufede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this env var to test previous tracers, don't we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants