Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email HTML Injection detection in IAST Java #3906

Merged
merged 19 commits into from
Feb 6, 2025

Conversation

sezen-datadog
Copy link
Contributor

@sezen-datadog sezen-datadog commented Jan 28, 2025

Motivation

This code covers the system tests for Email HTML injection detection in IAST for java

Changes

Implementation of insecure and secure tests for sending email in java
APPSEC-56330

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@sezen-datadog sezen-datadog added java Pull requests that update Java code run-appsec-scenarios labels Jan 29, 2025
@sezen-datadog sezen-datadog marked this pull request as ready for review January 30, 2025 08:10
@sezen-datadog sezen-datadog requested review from a team as code owners January 30, 2025 08:10
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@sezen-datadog sezen-datadog marked this pull request as draft January 30, 2025 08:44
@sezen-datadog sezen-datadog marked this pull request as ready for review February 5, 2025 13:20
Copy link
Contributor

@Mariovido Mariovido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the version must be changed as the feature will be added in the next release and not the current one

manifests/java.yml Outdated Show resolved Hide resolved
manifests/java.yml Outdated Show resolved Hide resolved
@sezen-datadog sezen-datadog requested a review from a team as a code owner February 5, 2025 13:47
@sezen-datadog sezen-datadog requested review from liustanley and removed request for a team February 5, 2025 13:47
@sezen-datadog sezen-datadog dismissed stale reviews from Mariovido and cbeauchesne February 5, 2025 14:32

done

Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure are not related

@sezen-datadog sezen-datadog merged commit 473c7e5 into main Feb 6, 2025
430 of 434 checks passed
@sezen-datadog sezen-datadog deleted the sezen.leblay/email-html-injection-java branch February 6, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code run-appsec-scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants