Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy to copy private key path to pulumi env #1262

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jack0x2
Copy link
Contributor

@jack0x2 jack0x2 commented Nov 25, 2024

What does this PR do?

Adds defaultPrivateKeyPath to pulumi environment.

Which scenarios this will impact?

On windows caused errors running inv aws.create-vm. Could not connect via ssh to provision and setup the VM with the agent.

Motivation

Fixes above problem

Additional Notes

@jack0x2 jack0x2 requested a review from a team as a code owner November 25, 2024 19:56
@jack0x2
Copy link
Contributor Author

jack0x2 commented Dec 20, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-20 14:55:42 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 2m.


2024-12-20 14:56:56 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 1c919e8 into main Dec 20, 2024
10 checks passed
@dd-mergequeue dd-mergequeue bot deleted the jack.phillips/add-private-key-path-aws branch December 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants