Fix

DataJunction · Dec 12, 2023 · 2741dee · 2741dee
1 parent 42dae82
commit 2741dee
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/datajunction-clients/python/datajunction/_internal.py b/datajunction-clients/python/datajunction/_internal.py
@@ -109,7 +109,10 @@ def request(self, method, url, *args, **kwargs):
             if not exc.response:
                 error_message = str(exc)
                 print(error_message)
-            if exc.response and exc.response.headers.get("Content-Type") == "application/json":
+            if (
+                exc.response
+                and exc.response.headers.get("Content-Type") == "application/json"
+            ):
                 error_message = exc.response.json().get("message")
             if not error_message:
                 error_message = (

diff --git a/datajunction-clients/python/datajunction/compile.py b/datajunction-clients/python/datajunction/compile.py
@@ -847,7 +847,7 @@ def load_node_configs_notebook_safe(repository: Path, priority: List[str]):
 async def load_node_configs(
     repository: Path,
     priority: List[str],
-) -> List[NodeYAML]:
+) -> List[Optional[NodeConfig]]:
     """
     Load all configs from a repository.
     """

diff --git a/datajunction-server/tests/api/namespaces_test.py b/datajunction-server/tests/api/namespaces_test.py
@@ -607,6 +607,7 @@ def test_export_namespaces(client_with_examples: TestClient):
         "/nodes/cube/",
         json={
             "name": "default.example_cube",
+            "display_name": "Example Cube",
             "description": "An example cube so that the export path is tested",
             "metrics": ["default.num_repair_orders"],
             "dimensions": ["default.hard_hat.city"],
@@ -618,7 +619,16 @@ def test_export_namespaces(client_with_examples: TestClient):
         "/namespaces/default/export/",
     )
     project_definition = response.json()
-    assert {d["filename"] for d in project_definition} == {
+    node_defs = {d["filename"]: d for d in project_definition}
+    assert node_defs["example_cube.cube.yaml"] == {
+        "description": "An example cube so that the export path is tested",
+        "dimensions": ["default.hard_hat.city"],
+        "directory": "",
+        "display_name": "Example Cube",
+        "filename": "example_cube.cube.yaml",
+        "metrics": ["default.num_repair_orders"],
+    }
+    assert set(node_defs.keys()) == {
         "repair_orders.source.yaml",
         "repair_order_details.source.yaml",
         "repair_type.source.yaml",