Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with displaying required dimensions for metrics #1296

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix bug with displaying required dimensions for metrics #1296

merged 1 commit into from
Jan 29, 2025

Conversation

shangyian
Copy link
Contributor

@shangyian shangyian commented Jan 29, 2025 •
edited
Loading

Summary

When displaying metrics with required dimensions, the DJ UI errors out because it doesn't pick the dimension's name field.

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

ASAP

@netlify Netlify
Copy link

netlify bot commented Jan 29, 2025 •
edited
Loading

✅ Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit 5cf565f
🔍 Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/67998218f32faa0008f356f1

@shangyian shangyian marked this pull request as ready for review January 29, 2025 01:19
@shangyian shangyian merged commit aa7aa38 into DataJunction:main Jan 29, 2025
16 checks passed
@shangyian shangyian deleted the metrics-required-dims-bug branch January 29, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agorajek agorajek Awaiting requested review from agorajek

@samredai samredai Awaiting requested review from samredai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shangyian