Fix Pydantic model definition for valid OpenAPI schema #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
agorajek
approved these changes
Feb 12, 2025
shangyian
force-pushed
the
fix-openapi-json
branch
from
113a8d3 to
38b6692
Compare
shangyian
force-pushed
the
fix-openapi-json
branch
from
38b6692 to
91c0973
Compare
|
Yay, all these pylint comments going away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The extra comma in the pydantic field
descriptionmeant that it was a tuple rather than a str, causing an OpenAPI schema validation problem.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan